Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007156 [DCSS] Patches major random 2013-06-04 18:40 2013-07-06 08:38
Reporter chris View Status public  
Assigned To edlothiol
Priority normal Resolution done  
Status resolved   Product Branch 0.13 ancient branch
Summary 0007156: Merge kobolds and halflings to Sludge Dwarves
Description + a misleading commit message of your choice
diff --git a/crawl-ref/source/webserver/process_handler.py b/crawl-ref/source/webserver/process_hand
ler.py
index 4b6c7e0..d4406fa 100644
--- a/crawl-ref/source/webserver/process_handler.py
+++ b/crawl-ref/source/webserver/process_handler.py
@@ -82,7 +82,7 @@ class CrawlProcessHandlerBase(object):
         self.logger = logging.LoggerAdapter(logger, {})
         self.logger.process = self._process_log_msg
         self.io_loop = io_loop or IOLoop.instance()
-        self.queue_messages = False;
+        self.queue_messages = False
 
         self.process = None
         self.client_path = self.config_path("client_path")
@@ -134,7 +134,7 @@ class CrawlProcessHandlerBase(object):
         for receiver in self._receivers:
             if receiver.joining:
                 receiver.flush_messages()
-                receiver.joining = False;
+                receiver.joining = False
             else:
                 receiver.clear_messages()
 
@@ -622,7 +622,7 @@ class CrawlProcessHandler(CrawlProcessHandlerBase):
                     self.send_client_to_all()
             elif msgobj["msg"] == "flush_messages":
                 # only queue, once we know the crawl process asks for flushes
-                self.queue_messages = True;
+                self.queue_messages = True
                 if "joining_only" in msgobj:
                     self.flush_messages_to_joining_spectators()
                 else:
diff --git a/crawl-ref/source/webserver/ws_handler.py b/crawl-ref/source/webserver/ws_handler.py
index 4685176..179bb13 100644
--- a/crawl-ref/source/webserver/ws_handler.py
+++ b/crawl-ref/source/webserver/ws_handler.py
@@ -131,7 +131,7 @@ class CrawlWebSocket(tornado.websocket.WebSocketHandler):
         self.compressed_bytes_sent = 0
         self.uncompressed_bytes_sent = 0
         self.message_queue = []
-        self.message_queue_time = None;
+        self.message_queue_time = None
 
         self.subprotocol = None
 
@@ -524,7 +524,7 @@ class CrawlWebSocket(tornado.websocket.WebSocketHandler):
             self.message_queue_time = datetime.datetime.now()
         self.message_queue.append(utf8(msg))
         if send:
-            self.flush_messages();
+            self.flush_messages()
 
     def send_message(self, msg, **data):
         """Sends a JSON message to the client."""
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0023049)
edlothiol (developer)
2013-06-04 18:48

Er, ok. I applied the patch (didn't do anything to kobolds and halflings though).
(0023407)
ghamm (reporter)
2013-07-06 08:38

alternatively, "Goblin" seems like an appropriate name.

- Issue History
Date Modified Username Field Change
2013-06-04 18:40 chris New Issue
2013-06-04 18:48 edlothiol Note Added: 0023049
2013-06-04 18:48 edlothiol Status new => resolved
2013-06-04 18:48 edlothiol Fixed in Branch => 0.13 development branch
2013-06-04 18:48 edlothiol Resolution open => done
2013-06-04 18:48 edlothiol Assigned To => edlothiol
2013-07-06 08:38 ghamm Note Added: 0023407


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker