|Anonymous | Login | Signup for a new account||2019-07-19 08:43 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0007107||[DCSS] Bug Report||minor||always||2013-05-30 11:28||2013-06-07 08:53|
|Status||resolved||Product Branch||0.13 ancient branch|
|Summary||0007107: Djinni level up notes record separate HP/MP|
The character note generated by level_change in player.cc uses get_real_hp and get_real_mp to record actual stats unaffected by temporary buffs. Unfortunately this avoids the merging of the two in calc_hp for djinni. It also checks against this incorrect value when it caps the reported hp total. In order to get the permanent stats, level_change will possibly need to have a special case to add hp+mp itself.
Attached is a patch which special cases the string construction, so that djinni don't even report MP in their notes. I've tentatively left the label as "HP". Not sure if "EP" or something is more appropriate.
djinni_level_notes.patch [^] (1,025 bytes) 2013-05-30 11:28 [Show Content]
djinni_level_notes_updated.patch [^] (1,425 bytes) 2013-05-31 02:28 [Show Content]
Ok, after a nap I fixed some style issues with my patch. (Forgot I was using the vimrc with 2-space indentation, etc.)
Also based on 18b0d3, I went ahead and made the note EP instead of HP.
The updated patch is the one that should be applied, if any.
|Applied in trunk (0.13-a0-1488-g5bd0de3), thanks!|
|2013-05-30 11:28||qoala||New Issue|
|2013-05-30 11:28||qoala||File Added: djinni_level_notes.patch|
|2013-05-31 02:28||qoala||File Added: djinni_level_notes_updated.patch|
|2013-05-31 02:30||qoala||Note Added: 0022953|
|2013-06-05 11:31||mumra||Tag Attached: has patch|
|2013-06-07 08:53||neil||Note Added: 0023099|
|2013-06-07 08:53||neil||Status||new => resolved|
|2013-06-07 08:53||neil||Fixed in Branch||=> 0.13 development branch|
|2013-06-07 08:53||neil||Resolution||open => done|
|2013-06-07 08:53||neil||Assigned To||=> neil|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|