Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006958 [DCSS] Bug Report minor always 2013-04-24 17:07 2013-08-10 22:46
Reporter BlackSheep View Status public  
Assigned To neil
Priority normal Resolution done  
Status closed   Product Branch 0.12 ancient branch
Summary 0006958: Finesse does not speed up throwing attacks
Description Finesse does not reduce the speed of Throwing attacks. (Blowguns are accelerated, just not items thrown by hand.)

As far as I can tell, this has always been the case, but it seems like an odd exception.
Additional Information
Tags patch
Attached Files ? file icon 0001-Make-finesse-apply-to-throwing-attacks.patch [^] (1,075 bytes) 2013-04-24 19:00 [Show Content]

- Relationships

-  Notes
(0022422)
BlackSheep (reporter)
2013-04-24 19:02

I created a patch by borrowing code.

In the process I noticed that melee attacks use div_rand_round but launcher attacks use speed /= 2. Seems inconsistent.
(0023701)
neil (administrator)
2013-08-10 10:57

Applied in trunk (0.13-a0-2664-g0922e12), thanks! I also refactored the duplicated code into a function finesse_adjust_delay(), and in the process fixed the division inconsistency you noted.

- Issue History
Date Modified Username Field Change
2013-04-24 17:07 BlackSheep New Issue
2013-04-24 19:00 BlackSheep File Added: 0001-Make-finesse-apply-to-throwing-attacks.patch
2013-04-24 19:02 BlackSheep Note Added: 0022422
2013-04-27 02:57 BlackSheep Tag Attached: patch
2013-08-10 10:12 neil Status new => assigned
2013-08-10 10:12 neil Assigned To => neil
2013-08-10 10:57 neil Note Added: 0023701
2013-08-10 10:57 neil Status assigned => resolved
2013-08-10 10:57 neil Fixed in Branch => 0.13 development branch
2013-08-10 10:57 neil Resolution open => done
2013-08-10 22:46 BlackSheep Status resolved => closed


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker