Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006889 [DCSS] Patches tweak N/A 2013-04-07 04:22 2013-04-08 21:43
Reporter infiniplex View Status public  
Assigned To mumra
Priority normal Resolution done  
Status resolved   Product Branch 0.13 ancient branch
Summary 0006889: A very minor fix to the LUA make_circle command
Description This fixes a minor inconsistency between the LUA make_circle command and the parallel make_diamond, make_square, and make_rounded_square commands. Previously, the make_circle command made a circle that did not look very circular on small sizes (radius <= 3ish) and that was cell smaller on each side. This fixes the circles to be comparable the others. The cell positions are checked against radius + 0.5 to avoid having a single glyph placed on the outside row.

I have also adjusted the two places the function is used. As the function no longer places a single glyph for radius 1, the beautification hack in the big octagon layout in layout.des is no longer needed.
Additional Information
Tags No tags attached.
Attached Files ? file icon 0001-Improved-draw_circle-LUA-command.patch [^] (2,330 bytes) 2013-04-07 04:22 [Show Content]

- Relationships

-  Notes
mumra (developer)
2013-04-08 21:42

Pushed to trunk now, thanks.

I also slightly fixed layout_big_octagon - seems some testing code was left in from donkeys years ago which meant only the diamond shape was ever actually used.

- Issue History
Date Modified Username Field Change
2013-04-07 04:22 infiniplex New Issue
2013-04-07 04:22 infiniplex File Added: 0001-Improved-draw_circle-LUA-command.patch
2013-04-08 21:42 mumra Note Added: 0022209
2013-04-08 21:42 mumra Status new => resolved
2013-04-08 21:42 mumra Fixed in Branch => 0.13 development branch
2013-04-08 21:42 mumra Resolution open => done
2013-04-08 21:42 mumra Assigned To => mumra

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker