Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006417 [DCSS] Bug Report major have not tried 2012-11-29 18:13 2012-12-01 22:16
Reporter elliptic View Status public  
Assigned To KiloByte
Priority normal Resolution done  
Status resolved   Product Branch 0.12 ancient branch
Summary 0006417: No Pandemonium portal generated
Description The encompass vault hangedman_slaughterboxes was generated on D:24 (the only level with a guaranteed Pan portal) and it did not place a Pan portal, though it did place a Hell portal.
Additional Information
Tags No tags attached.
Attached Files ? file icon 0001-hangedman_slaughterboxes-must-have-a-pan-portal-if-g.patch [^] (1,654 bytes) 2012-11-29 18:53 [Show Content]
? file icon 0001-Fixed-0006417-pan-and-other-guarenteed-portals-not-b.patch [^] (1,168 bytes) 2012-12-01 21:45 [Show Content]

- Relationships

-  Notes
(0020583)
Kellhus (reporter)
2012-11-29 18:49

The same happened for me with grunt_twisty_little_passages encompass vault.
(0020584)
mrwooster (reporter)
2012-11-29 18:54
edited on: 2012-11-29 18:57

patch uploaded for hangedman.... just getting into craw development so please feel free to slate me if I have done it completely wrong

(0020592)
jeffqyzt (reporter)
2012-11-30 22:38

^ Ideally, you wouldn't want to have to manually add a depth check + guaranteed pan portal for each encompass vault whose range happens to span D24. Although I suppose if it's only for 'generator' vaults, it might not be too bad.
(0020594)
Claws (developer)
2012-12-01 00:26

I think that since this bug hasn't cropped up before on other encompass vaults it has to do with the implementation of MARKER: ^ = lua:props_marker { portal=1 } Grunt did a while back, in that it probably doesn't respect the guarantees for Pan on D:24 and Abyss on D:25. There are a total of four encompass vaults (both of mine and both of Grunt's in encompass.des) that use this lua marker, so it'd probably be better to make the lua marker smarter instead of having such an edge issue be around.
(0020595)
mrwooster (reporter)
2012-12-01 00:58

Ok, I wouldnt mind taking a crack at this over the weekend if no one objects.
(0020599)
guyht (reporter)
2012-12-01 21:46

This was being caused because the portal placement code did not check to see if a portal had already been placed in that position... so it would place a pan portal, then a hell portal in the same place.

Patch attached.
(0020600)
KiloByte (manager)
2012-12-01 22:16

Looks like your second patch fixes the issue, thanks!

- Issue History
Date Modified Username Field Change
2012-11-29 18:13 elliptic New Issue
2012-11-29 18:49 Kellhus Note Added: 0020583
2012-11-29 18:53 mrwooster File Added: 0001-hangedman_slaughterboxes-must-have-a-pan-portal-if-g.patch
2012-11-29 18:54 mrwooster Note Added: 0020584
2012-11-29 18:57 mrwooster Note Edited: 0020584
2012-11-30 22:38 jeffqyzt Note Added: 0020592
2012-12-01 00:26 Claws Note Added: 0020594
2012-12-01 00:58 mrwooster Note Added: 0020595
2012-12-01 21:45 guyht File Added: 0001-Fixed-0006417-pan-and-other-guarenteed-portals-not-b.patch
2012-12-01 21:46 guyht Note Added: 0020599
2012-12-01 22:16 KiloByte Note Added: 0020600
2012-12-01 22:16 KiloByte Status new => resolved
2012-12-01 22:16 KiloByte Fixed in Branch => 0.12 development branch
2012-12-01 22:16 KiloByte Resolution open => done
2012-12-01 22:16 KiloByte Assigned To => KiloByte


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker