0006147: Teleporter teleport onto monster teleports it out of the way

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006147

[DCSS] Bug Report

minor

always

2012-09-02 02:34

2012-11-24 20:59

Reporter

infiniplex

View Status

public

Assigned To

Kate

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.11 ancient branch

Summary

0006147: Teleporter teleport onto monster teleports it out of the way

Description

There exists a LUA function for vault desgn that teleports the player. It is used in the Roulette of Golubria wizlab (and other places).

you.teleport_to(my_slaves[1].x, my_slaves[1].y, true)

If this function teleports the player on top of a monster, the monster is teleported (I think randomly). If the monster was visible before, there is a message: "_____ disappears!"

I suspect that this behaviour is unintentional because the function is always wrapped in an if block to handle the case it fails. I also suspect that the code to use this function was written once and repeatedly copied, but that is besides the point.

  if you.teleport_to(my_slaves[1].x, my_slaves[1].y, true) then
    crawl.mpr("Your surroundings suddenly seem different!")
  else
    crawl.mpr("There is a strange hissing noise.")
  end

I assumed that this function would fail (and return false) if the target cell was occupied.

Monsters refuse to step on these teleporters (is this a bug?), so I was unable to test if the player could also be bumped.

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0019843) neil (administrator) 2012-09-02 08:40	The third parameter to you.teleport_to() is "should monsters be teleported away?". Its use in the_teleporter has been there since 0.6.0-a1-1307-g9dc6a97 , but before that there was special-case code to move any monsters at the destination. So at least for the_teleporter the displacement is intentional. For wizlab_golubria, I'd like input from HangedMan/Claws.

(0019959) infiniplex (reporter) 2012-09-06 01:46	Thank you. This issue can probably be marked as resolved.

(0020559) Kate (developer) 2012-11-24 20:59	Resolving as requested.

Issue History
Date Modified	Username	Field	Change
2012-09-02 02:34	infiniplex	New Issue
2012-09-02 08:40	neil	Note Added: 0019843
2012-09-06 01:46	infiniplex	Note Added: 0019959
2012-11-24 20:59	Kate	Note Added: 0020559
2012-11-24 20:59	Kate	Status	new => resolved
2012-11-24 20:59	Kate	Fixed in Branch	=> 0.12 development branch
2012-11-24 20:59	Kate	Resolution	open => done
2012-11-24 20:59	Kate	Assigned To	=> Kate

Mantis 1.1.8[^]