|Anonymous | Login | Signup for a new account||2019-04-20 12:55 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0005938||[DCSS] Bug Report||minor||always||2012-07-16 11:01||2014-11-05 09:52|
|Status||closed||Product Branch||0.11 ancient branch|
|Summary||0005938: declaring jewellery "cursed" in a vault doesn't work|
Adding something like "ITEM: amulet of stasis cursed" in a vault doesn't force creation of a cursed item because mapdef.cc:line 4818 only sets item level to ISPEC_BAD, and ISPEC_BAD is ignored in _generate_jewellery_item() [makeitem.cc:2915-2989] (the only effect of ISPEC_BAD is that it disallows turning the item into a randart, because the "item_level>2" check in makeitem.cc:line 2978 returns false).
A posssible workaround is writing something like "ITEM: amulet of stasis mundane cursed", because "mundane" activates the check in mapdef.cc:line 4812 which adds the "cursed" property to the item specification which is handled properly in dungeon.cc:line 4054. This workaround also disallows generation of randarts as a side effect of "mundane".
I suggest renaming the current common effect of "cursed" (setting item level to ISPEC_BAD) to "baditem" or something similar (and mentioning in its documentation that it doesn't work with jewellery); and letting the "cursed" flag always set props["cursed"] (like in mapdef.cc:line 4812-13). In this case the handling of props["cursed"] in dungeon.cc:line 4054 probably requires a check against cursed weapons of holy wrath.
|Tags||No tags attached.|
Implemented in trunk (0.16-a0-1891-g9d79221), thanks! I took all of your suggestion except renaming the tag: "cursed" now sets the property in addition to its other effects, and the documentation for "damaged" mentions that it (and the plusses part of cursed) does not work for jewellery.
The only reason I didn't rename the tag is because I didn't want to go through all the vaults replacing it just yet.
|2012-07-16 11:01||nagdon||New Issue|
|2013-03-14 01:25||mumra||Issue Monitored: mumra|
|2014-11-05 07:02||neil||Note Added: 0027649|
|2014-11-05 07:02||neil||Status||new => resolved|
|2014-11-05 07:02||neil||Fixed in Branch||=> 0.16 development branch|
|2014-11-05 07:02||neil||Resolution||open => done|
|2014-11-05 07:02||neil||Assigned To||=> neil|
|2014-11-05 09:52||nagdon||Status||resolved => closed|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|