Main | My View | View Issues | Change Log | Wiki | Tavern | News
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0005674 [DCSS] Bug Report trivial have not tried 2012-05-16 21:51 2013-12-19 15:17
Reporter nagdon View Status public  
Assigned To neil
Priority normal Resolution done  
Status closed   Product Branch 0.11 ancient branch
Summary 0005674: typo in pluralise()
Description The case in lines 451-452 contradicts the comment in line 450; to handle the case described in line 450 (sensibility -> sensibilities); line 452 should be

else if (name[name.length() - 3] == 'i')

but then the case when the length of name is only 2 needs special handling.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0018078)
neil (administrator)
2012-05-16 22:11

 That case wouldn't even be needed. No English nouns end in iVy (where V is a vowel), and if one did it would probably be pluralised the same as other -Vy words: by adding s.

However, the commit history shows that this was intended to handle a different case ( https://gitorious.org/crawl/crawl/commits/fccc5c8d [^] ): "sensibilitiy". Since—despite the claims of SCOWL's insane dictionary—this is not a word, there is no reason to handle that case.
(0018079)
neil (administrator)
2012-05-16 22:44

 Fixed in trunk (0.11-a0-1866-gd17ad6a).

- Issue History
Date Modified Username Field Change
2012-05-16 21:51 nagdon New Issue
2012-05-16 22:11 neil Note Added: 0018078
2012-05-16 22:44 neil Note Added: 0018079
2012-05-16 22:44 neil Status new => resolved
2012-05-16 22:44 neil Fixed in Branch => 0.11 development branch
2012-05-16 22:44 neil Resolution open => done
2012-05-16 22:44 neil Assigned To => neil
2013-12-19 15:17 nagdon Status resolved => closed

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker