Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0005641 [DCSS] Bug Report crash always 2012-05-05 16:09 2012-10-02 13:23
Reporter KiloByte View Status public  
Assigned To KiloByte
Priority normal Resolution done  
Status resolved   Product Branch 0.11 ancient branch
Summary 0005641: _you_vault_list overflows
Description If you sit in the Abyss or Pan long enough, _you_vault_list will overflow. For example, if you run ./crawl -rc test/stress/abyss.rc, and there's no current crasher bug, you will run into it after an hour or so (depends on machine speed, optimizations, etc, of course).

Also, it seems unseen vaults will repeat there, even though the rest of Abyss code pretends they never spawned.

I'm not sure what's the best way to fix this -- should we just ignore it, or perhaps add a counter?
Additional Information
Tags patch
Attached Files ? file icon crawl-0005641-level-state-reset.patch [^] (1,356 bytes) 2012-06-17 21:41 [Show Content]

- Relationships

-  Notes
(0017992)
neil (administrator)
2012-05-07 02:45
edited on: 2012-05-07 03:15

can it be cleared on _abyss_generate_new_area() ?

(0018455)
sgrunt (administrator)
2012-06-17 21:44

Although I don't think I have the Abyss stress mentioned in the report, this is fairly easy to reproduce without it in wizard mode - just banish oneself and repeatedly abyss teleport to regenerate levels until a crash occurs.

In any case, I'm not particularly familiar with the level generation code, I'm wondering if there would be any overtly unintended side effects by calling dgn_reset_level() before starting to generate an Abyss or Pandemonium level (see attached patch); this would clear the vault list, amongst other things.
(0018594)
KiloByte (manager)
2012-06-26 22:08

I'd say it would be better to list all vaults that did generate, but merging duplicates.

For the stress test, ./crawl -rc test/stress/abyss.rc
(0020198)
KiloByte (manager)
2012-09-19 15:31

Grunt: your method of reproduction is not enough: neither &^A nor generating thousands of Pan levels trigger the crash for me.

One needs to walk around the Abyss, causing actual shifts -- and then, your patch doesn't fix the problem.
(0020302)
KiloByte (manager)
2012-10-02 13:23

This be an ex-bug.

- Issue History
Date Modified Username Field Change
2012-05-05 16:09 KiloByte New Issue
2012-05-07 02:45 neil Note Added: 0017992
2012-05-07 03:15 neil Note Edited: 0017992
2012-06-17 21:41 sgrunt File Added: crawl-0005641-level-state-reset.patch
2012-06-17 21:44 sgrunt Note Added: 0018455
2012-06-26 00:27 sgrunt Tag Attached: patch
2012-06-26 20:14 neil Status new => feedback
2012-06-26 22:08 KiloByte Note Added: 0018594
2012-09-19 15:31 KiloByte Note Added: 0020198
2012-10-02 13:23 KiloByte Note Added: 0020302
2012-10-02 13:23 KiloByte Status feedback => resolved
2012-10-02 13:23 KiloByte Fixed in Branch => 0.11 pre-release branch
2012-10-02 13:23 KiloByte Resolution open => done
2012-10-02 13:23 KiloByte Assigned To => KiloByte


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker