0005359: Lose xp&loot after a crash - Dungeon Crawl Stone Soup Tracker

(0017143)
Danakh (reporter)
2012-02-24 11:08

My wetiles user name is Danakh. You can use my games if needed, i was low level.
As webtiles is down right now, i can post screenshot or else

(0017144)
edlothiol (developer)
2012-02-24 11:10

This is normal when the game crashes. You'll get the last saved game, which is usually from the last time you changed levels.

(0017146)
Danakh (reporter)
2012-02-24 11:26

The save is inconsistent as the character was as entering the level, but the level was as at the moment the game crash.
I lose my summoning book ! :'(

Note that it really matters anyway, but the save process is broken

(0017147)
edlothiol (developer)
2012-02-24 11:30

Hm, ok, that's not supposed to happen.

(0017148)
Danakh (reporter)
2012-02-24 11:57

I confirm that the level was as it was at the moment of the crash. Discovered tiles was empty, some with skeletons of monsters I killed before the crash

The monsters I encounter just before the crash was still there, wandering

(0017149)
KiloByte (manager)
2012-02-24 11:59

The save system is transactional precisely to make saves either consistent or to fully roll back to the last consistent one.

However, I see that level excursions save only the level but not 1. your character, 2. metadata about the level (like place_info or travel cache). And it does commit (it has to, or X[][][][][] would take unlimited disk space, at least unless we add smart purging of data overwritten before it is committed).

(0017150)
KiloByte (manager)
2012-02-24 12:04

Danakh: could you confirm that you viewed other levels using X[] ? That's the only place I see that saves and commits the level map but not other data.

(0017151)
Danakh (reporter)
2012-02-24 13:31

I am not sure if i have done that before, but as the crash was caused by looking for shop (ctrl-F shop), and the shop was on another level, maybe it crashed just at the moment the view should have been on the shop.
Maybe it provoques the level save.

(0018386)
KiloByte (manager)
2012-06-12 18:22

Should be fixed now. Going on an X[[[[[ spree and looking at every level can now result in the save file doubling its size, but nothing more than that.

Issue History
Date Modified	Username	Field	Change
2012-02-24 11:07	Danakh	New Issue
2012-02-24 11:08	Danakh	Note Added: 0017143
2012-02-24 11:10	edlothiol	Note Added: 0017144
2012-02-24 11:10	edlothiol	Status	new => resolved
2012-02-24 11:10	edlothiol	Fixed in Branch	=> 0.10 stable branch
2012-02-24 11:10	edlothiol	Resolution	open => no change required
2012-02-24 11:10	edlothiol	Assigned To	=> edlothiol
2012-02-24 11:26	Danakh	Note Added: 0017146
2012-02-24 11:30	edlothiol	Assigned To	edlothiol =>
2012-02-24 11:30	edlothiol	Note Added: 0017147
2012-02-24 11:30	edlothiol	Status	resolved => feedback
2012-02-24 11:30	edlothiol	Resolution	no change required => reopened
2012-02-24 11:30	edlothiol	Status	feedback => acknowledged
2012-02-24 11:57	Danakh	Note Added: 0017148
2012-02-24 11:59	KiloByte	Note Added: 0017149
2012-02-24 12:04	KiloByte	Note Added: 0017150
2012-02-24 13:31	Danakh	Note Added: 0017151
2012-04-26 22:30	KiloByte	Reproducibility	unable to reproduce => always
2012-04-26 22:30	KiloByte	Resolution	reopened => open
2012-06-12 18:22	KiloByte	Note Added: 0018386
2012-06-12 18:22	KiloByte	Status	acknowledged => resolved
2012-06-12 18:22	KiloByte	Fixed in Branch	0.10 stable branch => 0.11 development branch
2012-06-12 18:22	KiloByte	Resolution	open => done
2012-06-12 18:22	KiloByte	Assigned To	=> KiloByte

Notes
(0017143) Danakh (reporter) 2012-02-24 11:08	My wetiles user name is Danakh. You can use my games if needed, i was low level. As webtiles is down right now, i can post screenshot or else

(0017144) edlothiol (developer) 2012-02-24 11:10	This is normal when the game crashes. You'll get the last saved game, which is usually from the last time you changed levels.

(0017146) Danakh (reporter) 2012-02-24 11:26	The save is inconsistent as the character was as entering the level, but the level was as at the moment the game crash. I lose my summoning book ! :'( Note that it really matters anyway, but the save process is broken

(0017147) edlothiol (developer) 2012-02-24 11:30	Hm, ok, that's not supposed to happen.

(0017148) Danakh (reporter) 2012-02-24 11:57	I confirm that the level was as it was at the moment of the crash. Discovered tiles was empty, some with skeletons of monsters I killed before the crash The monsters I encounter just before the crash was still there, wandering

(0017149) KiloByte (manager) 2012-02-24 11:59	The save system is transactional precisely to make saves either consistent or to fully roll back to the last consistent one. However, I see that level excursions save only the level but not 1. your character, 2. metadata about the level (like place_info or travel cache). And it does commit (it has to, or X[][][][][] would take unlimited disk space, at least unless we add smart purging of data overwritten before it is committed).

(0017150) KiloByte (manager) 2012-02-24 12:04	Danakh: could you confirm that you viewed other levels using X[] ? That's the only place I see that saves and commits the level map but not other data.

(0017151) Danakh (reporter) 2012-02-24 13:31	I am not sure if i have done that before, but as the crash was caused by looking for shop (ctrl-F shop), and the shop was on another level, maybe it crashed just at the moment the view should have been on the shop. Maybe it provoques the level save.

(0018386) KiloByte (manager) 2012-06-12 18:22	Should be fixed now. Going on an X[[[[[ spree and looking at every level can now result in the save file doubling its size, but nothing more than that.

Relationships