0005238: SQLite update breaks mac builds <10.6 - Dungeon Crawl Stone Soup Tracker

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005238

[DCSS] Bug Report

minor

always

2012-01-19 18:34

2012-01-20 22:43

Reporter

GreatZebu

View Status

public

Assigned To

KiloByte

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.10 ancient branch

Summary

0005238: SQLite update breaks mac builds <10.6

Description

SQLite was updated to a new version that by default doesn't compile correctly on Mac releases prior to 10.6 due to the lack of gethostuuid. To fix it we need a small patch to contrib/sqlite/Makefile:

diff --git a/Makefile b/Makefile
index ae60e65..d00c1c0 100644
--- a/Makefile
+++ b/Makefile
@@ -39,6 +39,10 @@ CFLAGS +=-DSQLITE_OMIT_AUTHORIZATION \
                 -DSQLITE_OMIT_LOAD_EXTENSION \
                 -DSQLITE_DEBUG=0 \
                 -w
+ifeq ($(shell uname -s),Darwin)
+ CFLAGS += -DSQLITE_ENABLE_LOCKING_STYLE=0
+endif
+

.PHONY: install

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0016775) KiloByte (manager) 2012-01-20 22:43	Fixed, thanks. There should be some detection, but for now, I applied the patch as-is.

Issue History
Date Modified	Username	Field	Change
2012-01-19 18:34	GreatZebu	New Issue
2012-01-20 22:43	KiloByte	Note Added: 0016775
2012-01-20 22:43	KiloByte	Status	new => resolved
2012-01-20 22:43	KiloByte	Fixed in Branch	=> 0.10 development branch
2012-01-20 22:43	KiloByte	Resolution	open => done
2012-01-20 22:43	KiloByte	Assigned To	=> KiloByte

Mantis 1.1.8[^]