Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0005185 [DCSS] Bug Report minor have not tried 2012-01-08 02:12 2014-06-11 17:02
Reporter KiloByte View Status public  
Assigned To wheals
Priority normal Resolution done  
Status resolved   Product Branch 0.10 ancient branch
Summary 0005185: friendly_pickup is overwritten
Description There's some explicit code to save the value of friendly_pickup... but then it's overwritten with "ally dropped only" every time a level is loaded.

However, there might be some reason for that overwriting. Does someone have a clue?
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0016573)
evilmike (developer)
2012-01-08 03:39

I think I know why it's doing this. In stairs.cc:

    if (newlevel)
    {
        // When entering a new level, reset friendly_pickup to default.
        you.friendly_pickup = Options.default_friendly_pickup;

So, this is intentional. I'm not sure why this is there though.

The default is FRIENDLY_PICKUP_FRIEND. You can change this with default_friendly_pickup in your init file.
(0016580)
jpeg (manager)
2012-01-08 11:48

My original thinking (the above is my code) was that if no matter how I changed the setting, I would always want my orcs not to pick up stuff lying on the ground in new levels.

Obviously, this behaviour is kinda unexpected and should probably be changed. Maybe an option could be added which governs whether to reset the setting to default for new levels.
(0026456)
wheals (administrator)
2014-06-11 17:02

The option has been removed.

- Issue History
Date Modified Username Field Change
2012-01-08 02:12 KiloByte New Issue
2012-01-08 03:39 evilmike Note Added: 0016573
2012-01-08 11:48 jpeg Note Added: 0016580
2014-06-11 17:02 wheals Note Added: 0026456
2014-06-11 17:02 wheals Status new => resolved
2014-06-11 17:02 wheals Fixed in Branch => 0.15 development branch
2014-06-11 17:02 wheals Resolution open => done
2014-06-11 17:02 wheals Assigned To => wheals


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker