0004867: Spriggan with Armor Skill under Ash cannot transfer knowledge out

(0015743)
Kyrris (reporter)
2011-11-07 10:33

My first suspicion is that you're wearing a robe and the Ash retraining builds off the ordinary training code, rendering Armour untouchable while not wearing something with an EVP.

(0015745)
XuaXua (reporter)
2011-11-07 14:51
edited on: 2011-11-08 23:19

If Sage magically gives me armor skills without having to wear any or actively train it, then Ash should divinely allow me to ditch the skill without having to wear armor to do it.

(0015747)
Happylisk (reporter)
2011-11-07 17:49

The problem isn't Ash not being able to transfer out the exp, the problem is getting Armor from Sage as a spriggan. Spriggans getting Armor from Sage is like Demigods getting Invocations or Felids getting Polearms.

(0015749)
ion_frigate (reporter)
2011-11-07 18:30

Happylisk: Not really, Armour is almost but not quite useless to Spriggans - they could, if they wanted, wear any dragon armour or troll leather armour, in which case the Armour skill isn't necessarily wasted. I do agree there's something wrong with the other examples though.

(0015750)
KiloByte (manager)
2011-11-07 18:33

What's wrong with spriggans in heavy armour? They don't have the best apt, but you can have a full plate's worth of AC for -3 EV.

(0015751)
Happylisk (reporter)
2011-11-07 18:37

Spriggans can wear dragon armors? That's good to know. In that case yeah, Ash transfer should not depend on wearing the armor.

(0018785)
neil (administrator)
2012-07-07 13:10

Fixed several months ago, well before the 0.10 release (0.10-a0-2407-g555c235).

(0018921)
XuaXua (reporter)
2012-07-11 16:42

Neil, if I may ask, what exactly was the fix that solved it?

(0018923)
neil (administrator)
2012-07-11 17:37
edited on: 2012-07-11 17:42

XuaXua: Normally you cannot select untrainable skills in the skill menu. The code was missing a special case to override this restriction for the "reskill from" variant of the menu:

-    if (!you.can_train[m_sk] && !is_set(SKMF_RESKILL_TO))
+    if (!you.can_train[m_sk] && !is_set(SKMF_RESKILL_TO)
+        && !is_set(SKMF_RESKILL_FROM))

Edit: you can view the whole commit at https://gitorious.org/crawl/crawl/commit/555c2353b7b1 [^]

(0018931)
Kyrris (reporter)
2012-07-11 23:25

*won*

(0018958)
XuaXua (reporter)
2012-07-12 18:43

Thanks for posting the code; I was curious!

Notes
(0015743) Kyrris (reporter) 2011-11-07 10:33	My first suspicion is that you're wearing a robe and the Ash retraining builds off the ordinary training code, rendering Armour untouchable while not wearing something with an EVP.

(0015745) XuaXua (reporter) 2011-11-07 14:51 edited on: 2011-11-08 23:19	If Sage magically gives me armor skills without having to wear any or actively train it, then Ash should divinely allow me to ditch the skill without having to wear armor to do it.

(0015747) Happylisk (reporter) 2011-11-07 17:49	The problem isn't Ash not being able to transfer out the exp, the problem is getting Armor from Sage as a spriggan. Spriggans getting Armor from Sage is like Demigods getting Invocations or Felids getting Polearms.

(0015749) ion_frigate (reporter) 2011-11-07 18:30	Happylisk: Not really, Armour is almost but not quite useless to Spriggans - they could, if they wanted, wear any dragon armour or troll leather armour, in which case the Armour skill isn't necessarily wasted. I do agree there's something wrong with the other examples though.

(0015750) KiloByte (manager) 2011-11-07 18:33	What's wrong with spriggans in heavy armour? They don't have the best apt, but you can have a full plate's worth of AC for -3 EV.

(0015751) Happylisk (reporter) 2011-11-07 18:37	Spriggans can wear dragon armors? That's good to know. In that case yeah, Ash transfer should not depend on wearing the armor.

(0018785) neil (administrator) 2012-07-07 13:10	Fixed several months ago, well before the 0.10 release (0.10-a0-2407-g555c235).

(0018921) XuaXua (reporter) 2012-07-11 16:42	Neil, if I may ask, what exactly was the fix that solved it?

(0018923) neil (administrator) 2012-07-11 17:37 edited on: 2012-07-11 17:42	XuaXua: Normally you cannot select untrainable skills in the skill menu. The code was missing a special case to override this restriction for the "reskill from" variant of the menu: - if (!you.can_train[m_sk] && !is_set(SKMF_RESKILL_TO)) + if (!you.can_train[m_sk] && !is_set(SKMF_RESKILL_TO) + && !is_set(SKMF_RESKILL_FROM)) Edit: you can view the whole commit at https://gitorious.org/crawl/crawl/commit/555c2353b7b1 [^]

(0018931) Kyrris (reporter) 2012-07-11 23:25	won

(0018958) XuaXua (reporter) 2012-07-12 18:43	Thanks for posting the code; I was curious!

Issue History
Date Modified	Username	Field	Change
2011-11-07 07:02	XuaXua	New Issue
2011-11-07 07:02	XuaXua	File Added: XuaXua.cs
2011-11-07 10:33	Kyrris	Note Added: 0015743
2011-11-07 14:51	XuaXua	Note Added: 0015745
2011-11-07 17:49	Happylisk	Note Added: 0015747
2011-11-07 18:30	ion_frigate	Note Added: 0015749
2011-11-07 18:33	KiloByte	Note Added: 0015750
2011-11-07 18:37	Happylisk	Note Added: 0015751
2011-11-08 23:19	XuaXua	Note Edited: 0015745
2012-07-07 13:10	neil	Note Added: 0018785
2012-07-07 13:10	neil	Status	new => resolved
2012-07-07 13:10	neil	Fixed in Branch	=> 0.10 stable branch
2012-07-07 13:10	neil	Resolution	open => done
2012-07-07 13:10	neil	Assigned To	=> neil
2012-07-11 16:42	XuaXua	Note Added: 0018921
2012-07-11 17:37	neil	Note Added: 0018923
2012-07-11 17:41	neil	Note Edited: 0018923
2012-07-11 17:42	neil	Note Edited: 0018923
2012-07-11 23:25	Kyrris	Note Added: 0018931
2012-07-12 18:43	XuaXua	Note Added: 0018958
2012-07-12 18:43	XuaXua	Status	resolved => closed

Relationships