0004818: monsters won't swap weapons - Dungeon Crawl Stone Soup Tracker

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0004818

[DCSS] Bug Report

minor

always

2011-10-27 02:26

2011-11-09 17:58

Reporter

Caethan

View Status

public

Assigned To

Kate

Priority

normal

Resolution

done

Status

closed

Product Branch

0.9 ancient branch

Summary

0004818: monsters won't swap weapons

Description

In versions 0.9.1 and later, most monsters will not ever switch to non-throwable melee weapons. This is due to a bug in monster::pickup_melee_weapon, in the monster.cc source file.

The lines
if (!_is_signature_weapon(this, item) && !dual_wielding)
return (false);
prevent a monster from replacing a non-throwable weapon if the new weapon is not "signature", even if its current weapon is also not "signature", which is true for nearly all monsters and weapons.

These lines should be replaced with
if (!_is_signature_weapon(this, item) && _is_signature_weapon(this, *weap) && !dual_wielding)
return (false);
which will only prevent weapon swaps to non-signature weapons if the monster is already wielding a signature weapon.

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0015566) Caethan (reporter) 2011-10-27 02:36	FYI, this is a large issue for worshipers of Beogh because it means there's no way to get your orcs to upgrade their weapons. Once they pick up that -2,-6 mace, they're stuck with it.

(0015568) Kate (developer) 2011-10-27 03:22	Thanks for reporting, fixed!

Issue History
Date Modified	Username	Field	Change
2011-10-27 02:26	Caethan	New Issue
2011-10-27 02:36	Caethan	Note Added: 0015566
2011-10-27 03:22	Kate	Note Added: 0015568
2011-10-27 03:22	Kate	Status	new => resolved
2011-10-27 03:22	Kate	Fixed in Branch	=> 0.10 development branch
2011-10-27 03:22	Kate	Resolution	open => done
2011-10-27 03:22	Kate	Assigned To	=> Kate
2011-11-09 17:58	Caethan	Status	resolved => closed

Mantis 1.1.8[^]