|Anonymous | Login | Signup for a new account||2019-04-23 22:47 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0004675||[DCSS] Bug Report||minor||have not tried||2011-10-03 15:55||2015-02-16 20:52|
|Status||resolved||Product Branch||0.10 ancient branch|
|Summary||0004675: Fire and Flame cloud discrepancy|
There's a little inconsistency in the uses of "fire" and "flame" when it comes to clouds (which resulted in me using the wrong type in the new cloud traps!)
There are two fire clouds in the enum: CLOUD_FIRE, and CLOUD_FOREST_FIRE.
However in _terse_cloud_names (which is used for parsing the cloud type in Lua calls), these are respectively "flame" and "fire".
Confusingly, in _verbose_cloud_names, they are *both* described as "roaring flames". But, _verbose_cloud_names appears to be used *solely* for an obscure check on rain clouds (with a comment "Special message for unmodified rain clouds"). At least, that is the only usage that I could find, perhaps I missed something.
a) Rename CLOUD_FIRE to CLOUD_FLAME
b) Remove _verbose_cloud_names (and implement that particular logic for rain in a slightly simpler fashion)?
|Tags||No tags attached.|
I'd rather fix CLOUD_FOREST_FIRE not telling people what it is.
I did implement it a long time ago but my memory is a bit cloudy. I think I did it this way because cloud code prepends "cloud of " in a number of places, and thus it was hard to explain that it's a burning tree rather than just hot air.
|Fixed in 08d921687a64c.|
|2011-10-03 15:55||mumra||New Issue|
|2011-10-03 21:37||KiloByte||Note Added: 0015020|
|2015-02-16 20:52||wheals||Note Added: 0028495|
|2015-02-16 20:52||wheals||Status||new => resolved|
|2015-02-16 20:52||wheals||Fixed in Branch||=> 0.16 development branch|
|2015-02-16 20:52||wheals||Resolution||open => done|
|2015-02-16 20:52||wheals||Assigned To||=> wheals|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|