Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0002971 [DCSS] Bug Report major always 2010-12-13 06:54 2011-03-03 22:33
Reporter jasonspiro View Status public  
Assigned To jpeg
Priority normal Resolution done  
Status resolved   Product Branch 0.7 ancient branch
Summary 0002971: Crawl makes it easy to accidentally run two copies of Crawl at once, and damage your game, on Windows.
Description In Crawl save file locking never happens on Windows: it requires fcntl(...F_SETLK...). A game of mine accidentally got damaged because I accidentally ran two copies of Crawl at once. It would be much appreciated if you'd do something to prevent such damage.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0009709)
KiloByte (manager)
2010-12-13 10:50

Yes, this is a grave bug. It has been fixed in 0.8 already, first for saves and recently for the database. It might be somewhat tricky to port the fix to 0.7 -- but the possible damage might warrant doing that.

What would you guys say?
(0009717)
evilmike (developer)
2010-12-13 13:56

This probably isn't something that will happen to people too often, but damaged saves are never a good thing. If porting the fix to 0.7 is difficult, maybe a less robust solution could be implemented in the time being, like making it so only one instance of crawl.exe can be loaded at a time (a fairly common behaviour for games in windows). Running multiple instances could be achieved through a command line option or something.
(0010621)
jasonspiro (reporter)
2011-01-24 02:18

I like evilmike's idea of forbidding multiple crawl instances in 0.7.x. And I don't see any need for letting people run multiple instances of 0.7.x at once, even with a command-line option. It's convenient but never necessary.
(0010622)
due (developer)
2011-01-24 02:39

jasonspiro: crawl.develz.org, crawl.akrasiac.org are two instances of public servers that require being able to run multiple instances of crawl at once.
(0011463)
jpeg (manager)
2011-03-03 22:33

I rather doubt we'll do another bugfix release for 0.7 with 0.8 this close.

- Issue History
Date Modified Username Field Change
2010-12-13 06:54 jasonspiro New Issue
2010-12-13 06:54 jasonspiro Issue Monitored: jasonspiro
2010-12-13 10:50 KiloByte Note Added: 0009709
2010-12-13 13:56 evilmike Note Added: 0009717
2011-01-24 02:18 jasonspiro Note Added: 0010621
2011-01-24 02:39 due Note Added: 0010622
2011-03-03 22:33 jpeg Note Added: 0011463
2011-03-03 22:33 jpeg Status new => resolved
2011-03-03 22:33 jpeg Fixed in Branch => 0.8 development branch
2011-03-03 22:33 jpeg Resolution open => done
2011-03-03 22:33 jpeg Assigned To => jpeg


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker