Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0002674 [DCSS] Patches minor N/A 2010-10-04 17:53 2010-10-06 15:39
Reporter galehar View Status public  
Assigned To KiloByte
Priority normal Resolution done  
Status closed   Product Branch 0.8 ancient branch
Summary 0002674: Merfolk tail and transforms overhaul
Description changes and bugfixes:
* Make the merfolk tail compatible with blade hands.
* Entering water doesn't cancel transformations. (Mantis 2110)
* Trying to enter deep water with a non-swimming form as a merfolk prints: "You cannot swim in your current form.". You have to manually cancel the transformation.
* Merfolk can cast all transformations in shallow water and blade hands and ice form in deep water. (Mantis 2384)
* Prevent turning into non-flying form (and being porkalated to death) when in a flying form above lava/deep water.
* Fix some messages (Mantis 1784, 2312, 2667).
* Fix some special cases where the merfolk doesn't untransform (Mantis 1104).
* When you change from one flying form to another over deep water, you no longer drown (extremly rare).
* Add new functions so that it should be much easier to add new swimming and flying forms.

bug not fixed:
* If you fly/levitate out of water, the player doll isn't updated properly and keeps its tail. I have no idea how to fix this, but if someone does, it now should be much easier to fix.

* A new boolean has been added to the player struct to track the status of the fishtail. Currently, it isn't saved (to preserve save compatibility), but as the status is checked after each step, this shouldn't be a problem. I put preprocessor directives so that it will be saved when the TAG_MAJOR_VERSION changes.
* Add 2 functions transform_can_fly and transform_can_swim and use them wherever possible.
transformation_can_wield has been renamed to transform_can_wield for consistency with all the other transform functions.
* replaced (you.species == SP_MERFOLK && you.swimming()) (and similar conditionals) by you.fishtail wherever possible.
Additional Information
Tags No tags attached.
Attached Files ? file icon 0001-Merfolk-tail-and-transforms-overhaul.patch [^] (28,358 bytes) 2010-10-04 17:53 [Show Content]

- Relationships

-  Notes
KiloByte (manager)
2010-10-04 21:07

Great work! Many thanks!


- Issue History
Date Modified Username Field Change
2010-10-04 17:53 galehar New Issue
2010-10-04 17:53 galehar File Added: 0001-Merfolk-tail-and-transforms-overhaul.patch
2010-10-04 21:07 KiloByte Note Added: 0008897
2010-10-04 21:07 KiloByte Status new => resolved
2010-10-04 21:07 KiloByte Fixed in Branch => 0.8 development branch
2010-10-04 21:07 KiloByte Resolution open => done
2010-10-04 21:07 KiloByte Assigned To => KiloByte
2010-10-06 15:39 galehar Status resolved => closed

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker