Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001778 [DCSS] Bug Report crash have not tried 2010-06-17 17:41 2010-09-13 14:05
Reporter greensnark View Status public  
Assigned To rob
Priority normal Resolution done  
Status resolved   Product Branch 0.6 ancient branch
Summary 0001778: Hiscores file corruption
Description A recent episode of scores corruption on CAO left a broken scores file, with Crawl asserting and dying every time it tried to read the scores file. While the broken scores file existed, no games could end (because Crawl asserts and dies before it can delete the old save files).

I've attached the broken scores file. The broken line is the one that starts with a :

We probably need to consider:

1. How the scores file got corrupted in the first place -- possible a race condition or some other bug in the hiscores code.

2. Crawl should not assert for broken scores lines, and simply discard malformed lines silently. It would still be good to find and fix the source of (1).

For the moment, I've disabled hiscores generation on CAO.
Additional Information
Tags No tags attached.
Attached Files ? file icon broken-0.6-scorefile [^] (392,771 bytes) 2010-06-17 17:41

- Relationships

-  Notes
(0005697)
KiloByte (manager)
2010-06-17 18:03

This is also one of remaining security issues on multiuser installs. It's nowhere as bad as the state of 0.6, but if we move saves to ~/.crawl and put the db either there or make it root:root mode 644, only the scores/log file and bones will remain as potential avenues for attack.
(0008558)
rob (developer)
2010-09-13 14:05

b4fccc77727f should fix these, right?

- Issue History
Date Modified Username Field Change
2010-06-17 17:41 greensnark New Issue
2010-06-17 17:41 greensnark File Added: broken-0.6-scorefile
2010-06-17 18:03 KiloByte Note Added: 0005697
2010-07-05 05:31 greensnark Status new => acknowledged
2010-09-13 14:05 rob Note Added: 0008558
2010-09-13 14:05 rob Status acknowledged => resolved
2010-09-13 14:05 rob Fixed in Branch => 0.8 development branch
2010-09-13 14:05 rob Resolution open => done
2010-09-13 14:05 rob Assigned To => rob


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker