0012370: For some reason LUAFN(dgn_map_by_tag) has a first and a third argument; but no second argument.

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0012370

[DCSS] Source Cleanup

minor

always

2020-10-05 05:26

2020-11-05 22:59

Reporter

bcadren

View Status

public

Assigned To

advil

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.26 old branch

Summary

0012370: For some reason LUAFN(dgn_map_by_tag) has a first and a third argument; but no second argument.

Description

As of right now this Lua function reads in the first argument as a map; and the third argument as a boolean and doesn't use the second argument at all.

changing line 1443 of l-dgn.cc from:
const bool check_depth = _lua_boolean(ls, 3, true);
to:
const bool check_depth = _lua_boolean(ls, 2, true);

Would make it use the second argument instead of the third. (Not sure if anything actually uses this third argument; I haven't grepped all the maps).

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0033922) advil (administrator) 2020-11-05 22:59	Fixed in: https://github.com/crawl/crawl/commit/cff87cac9a14b6813009e56f11b511241acbc4d8 [^]

Issue History
Date Modified	Username	Field	Change
2020-10-05 05:26	bcadren	New Issue
2020-11-05 22:59	advil	Note Added: 0033922
2020-11-05 22:59	advil	Status	new => resolved
2020-11-05 22:59	advil	Fixed in Branch	=> 0.26 development version
2020-11-05 22:59	advil	Resolution	open => done
2020-11-05 22:59	advil	Assigned To	=> advil

Mantis 1.1.8[^]