0012280: There's a line in _acquirement_weapon_subtype() which has no effect.

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0012280

[DCSS] Source Cleanup

trivial

always

2020-06-15 05:22

2020-12-13 15:36

Reporter

bcadren

View Status

public

Assigned To

ebering

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.26 old branch

Summary

0012280: There's a line in _acquirement_weapon_subtype() which has no effect.

Description

(actually all versions since, likely the introduction of formacids)

Line 484-486 of acquire.cc:

    const int shield_sk = you.species == SP_FORMICID
        ? 0
        : _skill_rdiv(SK_SHIELDS) * species_apt_factor(SK_SHIELDS);

The explanation for the exception just above is that it's so Formacids always weight towards 2Hers. However; since the handedness check considers the player's species, all weapons are 1Hers for Formacids, thus this exception is of no effect.

Recommendations:

1.) Existing behavior is fine; just remove the line and comment that are of no effect and maintain current behavior.

OR

2.) If we want Formacids to more strongly weight towards weapons that are normally 2Hed, add a special case in a different way; perhaps checking the handedness on a normal-sized monster like an orc. Note that they already do; slightly bias towards weapons that are normally 2Hers just by base-damage weighting.

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0033956) ebering (developer) 2020-12-13 15:36	Fixed in 0.26-a0-1067-g7c2e7382c0

Issue History
Date Modified	Username	Field	Change
2020-06-15 05:22	bcadren	New Issue
2020-12-13 15:36	ebering	Note Added: 0033956
2020-12-13 15:36	ebering	Status	new => resolved
2020-12-13 15:36	ebering	Resolution	open => done
2020-12-13 15:36	ebering	Assigned To	=> ebering

Mantis 1.1.8[^]