Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0012258 [DCSS] Bug Report minor always 2020-05-11 11:19 2020-05-11 11:19
Reporter bcadren View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Branch 0.25 stable branch
Summary 0012258: Sif and Kiku will not give book gifts if an aquatic player is standing in deep water
Description Additionally it's weird that the Oka/Trog gift code right above it duplicates the logic of "feat_eliminates_items()" instead of calling it. It's better practice to keep this in one centralized area for similar calls in case of later changes.

Both: 1350/1351

    if (!(feat_has_solid_floor(grd(you.pos()))
        || feat_is_watery(grd(you.pos())) && species_likes_water(you.species)))

and 1483:

    if (!feat_has_solid_floor(grd(you.pos())))

in really should be replaced with:

    if (feat_eliminates_items(grd(you.pos())))

This is a correction on earlier issue: "0012257: Sif and Kiku will not give book gifts if the player is standing in shallow water."
Additional Information
Tags No tags attached.
Attached Files

- Relationships

There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
2020-05-11 11:19 bcadren New Issue

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker