|Anonymous | Login | Signup for a new account||2019-08-24 14:02 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0001220||[DCSS] Bug Report||minor||always||2010-03-31 13:42||2014-10-03 04:43|
|Status||resolved||Product Branch||0.7 ancient branch|
|Summary||0001220: Jumping deliberately through a shaft doesn't show in Notes|
When standing on a shaft and entering it with '>' the notes only show
"You fall through a shaft!"
without a hint that it was on purpose.
|Tags||No tags attached.|
|Attached Files||0001-Correctly-show-the-appropriate-message-for-falling-d.patch [^] (1,086 bytes) 2010-12-06 17:19 [Show Content]|
As far as I can see there are two issues here, although only one is a bug. Currently, the "fall" message can be displayed even when you _choose_ to "dive" down a shaft.
Patch attached to fix this. It assumes that when you lose levitation/flight over a pre-discovered shaft, you are choosing to dive down it. This behaviour may not be desired, but another condition can be added if required.
The second issue, which actually addresses your report, is that the message displayed in the notes for shaft traversal is specified in your crawlrc. The default line:
note_messages = You fall through a shaft
is the one in question, and there is no counterpart for diving down shafts. If we really want falling AND diving down shafts to be mentioned in the notes, I propose that the line in the default init.txt is changed to:
note_messages = You.* through .*shaft
which covers both possibilities (and doesn't trigger anything else that I can think of).
Thanks for the clarification.
I didn't know that you could customize the notes. This explains to me why some things are in the notes and some not. :-)
|Fixed in 0.16-a0-1022-g6052d88.|
|2010-03-31 13:42||bhaak||New Issue|
|2010-12-06 17:18||ahpla||Note Added: 0009599|
|2010-12-06 17:19||ahpla||File Added: 0001-Correctly-show-the-appropriate-message-for-falling-d.patch|
|2010-12-13 12:30||bhaak||Note Added: 0009716|
|2014-10-03 04:43||wheals||Note Added: 0027411|
|2014-10-03 04:43||wheals||Status||new => resolved|
|2014-10-03 04:43||wheals||Fixed in Branch||=> 0.16 development branch|
|2014-10-03 04:43||wheals||Resolution||open => done|
|2014-10-03 04:43||wheals||Assigned To||=> wheals|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|