0012170: net trap revealed by magic mapping has wrong tile

(0033647)
aidanholm (developer)
2020-01-06 14:08

trap_category() maps the net trap_type -> mechanical dungeon_feature_type, since for some reason there are fewer feature types than trap types. Then tileidx_out_of_los() chooses the bg based on cell.feat() alone for magic-mapped cells.

(0033656)
hittemvvvhard (reporter)
2020-01-11 17:58

same issue for pressure plates looking like this

(0033716)
Goratrix (reporter)
2020-03-20 15:21
edited on: 2020-03-20 15:25

Just thinking, could this be resolved relatively easily (without reworking the types, etc...) by creating a new 'generic mechanical trap' tile image and then referencing it here?

https://github.com/crawl/crawl/blob/master/crawl-ref/source/tilepick.cc#L217 [^]

Or would that break tile display in some other situations?

The existing pressure plate tile (or some modification of it, adding a question mark or something) could work well.

(0033717)
Goratrix (reporter)
2020-03-20 19:14

Proposed fix sumbitted as PR 1323.

(0033774)
aidanholm (developer)
2020-04-16 19:38

(Permanent) teleport traps have the same problem.

(0033777)
aidanholm (developer)
2020-04-20 17:37

0.25-a0-825-g30a70f5

Notes
(0033647) aidanholm (developer) 2020-01-06 14:08	trap_category() maps the net trap_type -> mechanical dungeon_feature_type, since for some reason there are fewer feature types than trap types. Then tileidx_out_of_los() chooses the bg based on cell.feat() alone for magic-mapped cells.

(0033656) hittemvvvhard (reporter) 2020-01-11 17:58	same issue for pressure plates looking like this

(0033716) Goratrix (reporter) 2020-03-20 15:21 edited on: 2020-03-20 15:25	Just thinking, could this be resolved relatively easily (without reworking the types, etc...) by creating a new 'generic mechanical trap' tile image and then referencing it here? https://github.com/crawl/crawl/blob/master/crawl-ref/source/tilepick.cc#L217 [^] Or would that break tile display in some other situations? The existing pressure plate tile (or some modification of it, adding a question mark or something) could work well.

(0033717) Goratrix (reporter) 2020-03-20 19:14	Proposed fix sumbitted as PR 1323.

(0033774) aidanholm (developer) 2020-04-16 19:38	(Permanent) teleport traps have the same problem.

(0033777) aidanholm (developer) 2020-04-20 17:37	0.25-a0-825-g30a70f5

Issue History
Date Modified	Username	Field	Change
2020-01-04 17:08	hittemvvvhard	New Issue
2020-01-04 17:08	hittemvvvhard	File Added: SZJSXBj.png
2020-01-06 14:08	aidanholm	Note Added: 0033647
2020-01-11 17:58	hittemvvvhard	Note Added: 0033656
2020-03-20 15:21	Goratrix	Note Added: 0033716
2020-03-20 15:25	Goratrix	Note Edited: 0033716
2020-03-20 19:14	Goratrix	Note Added: 0033717
2020-04-16 19:38	aidanholm	Note Added: 0033774
2020-04-20 17:37	aidanholm	Note Added: 0033777
2020-04-20 17:37	aidanholm	Status	new => resolved
2020-04-20 17:37	aidanholm	Fixed in Branch	=> 0.25 development branch
2020-04-20 17:37	aidanholm	Resolution	open => done
2020-04-20 17:37	aidanholm	Assigned To	=> aidanholm

Relationships