 Notes |
(0033505)
damerell (reporter)
2019-10-12 23:20
|
I have an extremely wild guess that commit 0aaaf76a470532b4a48a69d386695e874d3f89fa is implicated. |
|
(0033511)
advil (administrator)
2019-10-16 01:12
edited on: 2019-10-16 01:16
|
What that macro file consists of is terminal escape codes, probably triggered by special keys under a specific terminal setting. E.g. \{27}Ov binds numpad 6 for vt100 terminal emulators. I can't identify the specific terminal being used in the file I looked at, which is ldf.macro, but it looks like a superset of VT100. They probably just bound the special keycodes by hitting the appropriate key with the right terminal setting. I've uploaded this file to the report in case it changes at the linked version.
The change that triggered this is: https://github.com/crawl/crawl/commit/3ea5ddb52caf [^]
We may want to revert that change, since anyone using these sorts of keybinds will now not be able to use a lot of keys that they were previously using. (And we'd definitely not want multi-char keybinds starting with ESC to be truncated to just ESC.)
|
|
(0033515)
advil (administrator)
2019-10-16 17:28
|
I have reverted this change in https://github.com/crawl/crawl/commit/72dcfe03596c23c1c632c9b6aa444db567820120 [^]
From more testing, this reversion will only impact CDO and local console builds in terms of being able to set and use these sorts of keybinds. I haven't been able to verify that multi-key keybinds work in any webtiles build, even over console, as far back as 0.10. (I tested using option+arrow keys on os x, which send two-key ESC sequences.) So this reversion may not make all of these macro files work; but it will prevent keybinds of this type from being interpreted as rebinds of esc. |
|
ldf.macro [^] (1,834 bytes) 2019-10-16 01:06 
