Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0012059 [DCSS] Bug Report crash always 2019-09-09 13:35 2019-09-18 15:33
Reporter nikopol View Status public  
Assigned To aidanholm
Priority normal Resolution done  
Status resolved   Product Branch 0.24 old branch
Summary 0012059: stuck in crash loop
Description i was going down from D14 to D15, and after displaying (partially?) the new level, the game has crashed. now, when i try to resume my "trunk" game, it crash the same way from the start. the funny part is that i don't know how to reset that game. so if the nightly build don't correct the issue, i'll be stuck in a crash loop forever (on this server for the "trunk" branch).

the game is on https://crawl.kelbi.org [^]

i've joined 2 crash reports from the morgue:
- when it crashed during the game
- when i try to resume the game
Additional Information
Tags No tags attached.
Attached Files txt file icon crash-nikopol-20190909-104102.txt [^] (56,275 bytes) 2019-09-09 13:35 [Show Content]
txt file icon crash-nikopol-20190909-110246.txt [^] (57,092 bytes) 2019-09-09 13:36 [Show Content]

- Relationships

-  Notes
(0033418)
killozap (reporter)
2019-09-09 13:53
edited on: 2019-09-09 13:54

Same problem appeared for me today on CBRO webtiles trunk, in Depths 5.
http://crawl.berotato.org/crawl/morgue/killozap/crash-killozap-20190909-095307.txt [^]

(0033419)
MrDizzy (reporter)
2019-09-09 13:59
edited on: 2019-09-09 14:18

I experienced what seems like the same crash on CPO webtiles trunk just after going down from Depths 4 to Depths 5:
https://crawl.project357.org/morgue/MrDizzy/crash-MrDizzy-20190909-114820.txt [^]

Every time I resume the game, it crashes again.

(0033420)
MrDizzy (reporter)
2019-09-09 14:48
edited on: 2019-09-09 15:20

Seems like the issue is on view.cc line 302 in _monster_headsup().
A recent commit replaced:
types[mon->type]
with:
types.at(mon->type)

The at() method throws an exception if the key doesn't exist in the map, and the key mon->type is not guaranteed to exist because _count_monster_types() will condense by genus, if possible, when there are more than 4 types.

Operator[] does not throw an exception when the key doesn't exist (it inserts a new element and returns the value).

I believe the fix is to revert back to using operator[].
Alternatively, if you want to avoid the automatic insert from operator[], you can use find() to check if the element exists before calling at().

(0033421)
aidanholm (developer)
2019-09-09 17:25

Thanks for the report and crashlogs; this should be fixed now at e11a5d91ad76.
(0033422)
MrDizzy (reporter)
2019-09-10 10:08

Thanks. It's working for me now on CPO.
(0033423)
nikopol (reporter)
2019-09-10 10:27
edited on: 2019-09-10 10:29

wow, that was quick =)
the fix has worked for me too, thanks !


- Issue History
Date Modified Username Field Change
2019-09-09 13:35 nikopol New Issue
2019-09-09 13:35 nikopol File Added: crash-nikopol-20190909-104102.txt
2019-09-09 13:36 nikopol File Added: crash-nikopol-20190909-110246.txt
2019-09-09 13:53 killozap Note Added: 0033418
2019-09-09 13:53 killozap Issue Monitored: killozap
2019-09-09 13:54 killozap Note Edited: 0033418
2019-09-09 13:59 MrDizzy Note Added: 0033419
2019-09-09 14:18 MrDizzy Note Edited: 0033419
2019-09-09 14:48 MrDizzy Note Added: 0033420
2019-09-09 14:50 MrDizzy Note Edited: 0033420
2019-09-09 14:50 MrDizzy Note Edited: 0033420
2019-09-09 14:55 MrDizzy Note Edited: 0033420
2019-09-09 15:02 MrDizzy Note Edited: 0033420
2019-09-09 15:02 MrDizzy Note Edited: 0033420
2019-09-09 15:19 MrDizzy Note Edited: 0033420
2019-09-09 15:20 MrDizzy Note Edited: 0033420
2019-09-09 17:25 aidanholm Note Added: 0033421
2019-09-10 10:08 MrDizzy Note Added: 0033422
2019-09-10 10:27 nikopol Note Added: 0033423
2019-09-10 10:29 nikopol Note Edited: 0033423
2019-09-18 15:32 aidanholm Status new => resolved
2019-09-18 15:32 aidanholm Fixed in Branch => 0.24 development branch
2019-09-18 15:32 aidanholm Resolution open => done
2019-09-18 15:32 aidanholm Assigned To => aidanholm


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker