0012003: Arcs of chaos from the mace of Variability can hit the player, despite saying the opposite in the mace's description

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0012003

[DCSS] Bug Report

minor

sometimes

2019-06-02 20:43

2019-06-03 17:51

Reporter

NormalPerson7

View Status

public

Assigned To

ebering

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.24 old branch

Summary

0012003: Arcs of chaos from the mace of Variability can hit the player, despite saying the opposite in the mace's description

Description

The +7 mace of Variability can create arcs of chaos, which are not supposed to hurt the wielder, a fact stated in the weapon's description:

A large mace said to have appeared when Xom grew bored with the predictability
of more ordinary instruments of chaos. Striking an enemy with this weapon will
occasionally unleash arcs of chaos upon any creatures nearby, leaving the
wielder unharmed.

However, these arcs of chaos can, in fact, hurt the player. From my testing, this occurs fairly reliably with two monsters on opposite sides of the player, and I have also confirmed that the player is hurt by these arcs as the messaging states. A snapshot of the messaging from one arc:

You sock the ettin! The ettin looks as sick as possible! The mace of
Variability scintillates.
A swirling arc of seething chaos appears!
The arc of chaos hits the ettin!
The ettin is lightly wounded.
The arc of chaos hits you.
You are poisoned.
The arc of chaos hits something. x2
The arc of chaos hits something but does no damage.

In my testing, I never had the arc of chaos hit me when it wasn't such that there were two monsters on directly opposite sides of me, so I think this is just an oversight that misses out on this specific case.

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0033297) ebering (developer) 2019-06-02 23:06	The source of this bug is that in cast_chain_spell in spl-damage.cc the chain spell set up makes beams that target the caster directly safe, but any beams that are targeted through the caster get no such special consideration. I think that, since the spell's beam is set to pierce = false, the intention with chain spells is that they don't fire through targets, and the real bug here is that they sometime do. So the solution to this bug is to fire a tracer for each arc and check that the given arc hits only one target (so foe_info.count + friend_info.count == 1). I'll maybe write the patch this evening but I'm leaving my notes in case someone beats me to it.

(0033304) ebering (developer) 2019-06-03 17:51	Fixed in 0.24-a0-382-g8e8615713e which also fixed the larger issue with chain spells.

Issue History
Date Modified	Username	Field	Change
2019-06-02 20:43	NormalPerson7	New Issue
2019-06-02 23:06	ebering	Note Added: 0033297
2019-06-03 17:51	ebering	Note Added: 0033304
2019-06-03 17:51	ebering	Status	new => resolved
2019-06-03 17:51	ebering	Fixed in Branch	=> 0.24 development branch
2019-06-03 17:51	ebering	Resolution	open => done
2019-06-03 17:51	ebering	Assigned To	=> ebering

Mantis 1.1.8[^]