Main | My View | View Issues | Change Log | Wiki | Tavern | News
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0011940 [DCSS] Bug Report trivial always 2019-03-30 17:21 2019-06-13 02:59
Reporter damerell View Status public  
Assigned To advil
Priority normal Resolution reopened  
Status new   Product Branch 0.23 ancient branch
Summary 0011940: Spurious message when opening door as WJC worshipper with "wall_jump_move = true"
Description If I am a WJC worshipper with sufficient piety to wall-jump, and have "wall_jump_move = true" set (no matter the value of wall_jump_prompt), and I attempt to move into a closed door in a position and direction such that it would be impossible to wall jump off the door, I get a message such as "You have no room to wall jump there; the orc is in the way" or "You have no room to wall jump there".

However, as the options guide says, "It is never possible to wall jump off of closed doors via movement", so whenever this message is seen after the player attempts to move into a door, it is spurious.

I've at least had a quick look in the trunk changelog in case there is a fix, and didn't see one.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0033205)
damerell (reporter)
2019-03-30 17:27

 Additionally, I haven't checked this bit, but I get blank lines in the log when opening a door in a position that doesn't generate these messages, like so:

_Some of the chunks of flesh in your inventory have rotted away.

_You open the door.

and I wouldn't care to lay odds this isn't symptomatic of the same issue.
(0033208)
NormalPerson7 (reporter)
2019-03-30 23:39

 I have a fix for this in PR 1024.
(0033209)
NormalPerson7 (reporter)
2019-03-31 22:48

 Fix merged in 0.24-a0-227-g1a43be2. Thanks for reporting.
(0033309)
damerell (reporter)
2019-06-13 02:59

 I'm afraid I closed this prematurely. The PR fixes the spurious message, but not the spurious blank message on opening any closed door with "wall_jump_move = true".

The blank message is seen because in the conditional in movement.cc, line 806 (if (!attacking && !targ_pass && !can_wall_jump && !running ...), no check is made that "wall_jump_err" is non-empty. (It can quite legitimately be empty; an empty string is put into it at the end of wu_jian_can_wall_jump, since in this case we _can_ wall jump off the door, we just will never do so by movement, so there is no error string to supply).

I submit such a check should be added.

While I'm on Wu Jian messaging, if you're in treeform and you select wall jump via the (a)bility menu, you are told "There is nothing to wall jump against here." I submit a check for "you.is_stationary()" could be added in
wu_jian_wall_jump_ability() to give a more useful message.

- Issue History
Date Modified Username Field Change
2019-03-30 17:21 damerell New Issue
2019-03-30 17:27 damerell Note Added: 0033205
2019-03-30 23:39 NormalPerson7 Note Added: 0033208
2019-03-31 22:48 NormalPerson7 Note Added: 0033209
2019-04-04 18:47 advil Status new => resolved
2019-04-04 18:47 advil Fixed in Branch => 0.24 development branch
2019-04-04 18:47 advil Resolution open => done
2019-04-04 18:47 advil Assigned To => advil
2019-06-13 02:14 damerell Status resolved => closed
2019-06-13 02:59 damerell Note Added: 0033309
2019-06-13 02:59 damerell Status closed => new
2019-06-13 02:59 damerell Resolution done => reopened

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker