0011926: Ghosts in ghost vaults with shafts can be shafted out of their vault

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0011926

[DCSS] Bug Report

minor

random

2019-03-16 22:51

2019-05-23 03:49

Reporter

NormalPerson7

View Status

public

Assigned To

ebering

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.24 old branch

Summary

0011926: Ghosts in ghost vaults with shafts can be shafted out of their vault

Description

The ghost vaults ebering_ghost_disaster_area and ebering_vaults_ghost_disaster_area place shafts, lava and water features. As of commit 8c2e593 ( https://github.com/crawl/crawl/commit/8c2e5930553569adb5138b76c1584a7ac91c6ffd [^] ), player ghosts can be shafted, which means that ghosts placed in these vaults can be shafted out of their vaults before the player can do anything about it, once the ghosts enter the player's line of sight. There are two problems associated with this:
- The ghost vault can now be looted with the player facing little immediate danger;
- The ghost will now be out in the open on a lower floor and not behind the protection of a ghost vault, so the player will be forced to fight the ghost (or engage in tedious run away tactics) when he/she next encounters it.

I propose four potential solutions to this problem, but these are not necessarily the only solutions. I would suggest that options 1 and 2 are preferable over options 3 and 4.
1. Revert commit 8c2e593 to prevent these ghosts from being shafted.
2. Change the aforementioned vaults to place only water and lava features and not place shafts in any circumstances.
3. Remove the vaults ebering_ghost_disaster_area and ebering_vaults_ghost_disaster_area. I'm including this one for completeness; it doesn't seem like a good option.
4. Come up with some special casing to prevent the ghosts in these ghost vaults from being shafted in their own vault. I'm not sure what this would involve.

Additional Information

Notes
(0033273) ebering (developer) 2019-05-23 03:49	This was fixed (by the reporter) in 0.24-a0-206-g696e1f2bf7

Issue History
Date Modified	Username	Field	Change
2019-03-16 22:51	NormalPerson7	New Issue
2019-05-23 03:49	ebering	Note Added: 0033273
2019-05-23 03:49	ebering	Status	new => resolved
2019-05-23 03:49	ebering	Fixed in Branch	=> 0.24 development branch
2019-05-23 03:49	ebering	Resolution	open => done
2019-05-23 03:49	ebering	Assigned To	=> ebering

Relationships