|
Viewing Issue Simple Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Advanced ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0011860 |
[DCSS] Bug Report |
minor |
always |
2019-02-07 06:50 |
2019-02-13 00:09 |
|
|
Reporter |
Sage1234 |
View Status |
public |
|
|
Assigned To |
|
|
Priority |
normal |
Resolution |
open |
|
|
Status |
new |
|
Product Branch |
experimental branch |
|
|
Summary |
0011860: Wand of digging reports indestructible wall is out of range |
|
Description |
I will include the screenshot but I was unable to destroy a wall that was out of range, it might be that this wall is the end of the map and indestructible.
IMHO the error should be changed to "Wall cannot be destroyed" or something to that effect. |
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Attached Files |
 digbug.PNG [^] (673,251 bytes) 2019-02-07 06:50
 dig.patch [^] (1,027 bytes) 2019-02-13 00:08 [Show Content] [Hide Content]diff --git a/crawl-ref/source/target.cc b/crawl-ref/source/target.cc
index c4529c555c..90a1ce5d4f 100644
--- a/crawl-ref/source/target.cc
+++ b/crawl-ref/source/target.cc
@@ -569,7 +569,7 @@ bool targeter_dig::valid_aim(coord_def a)
{
if (a == origin)
return notify_fail("Please select a direction to dig.");
- if ((origin - a).rdist() > range || !in_bounds(a))
+ if ((origin - a).rdist() > range)
return notify_fail("Out of range.");
int possible_squares_affected;
if (aim_test_cache.count(a))
@@ -584,8 +584,8 @@ bool targeter_dig::valid_aim(coord_def a)
{
possible_squares_affected = 0;
for (auto p : path_taken)
- if (beam.can_affect_wall(p) ||
- in_bounds(p) && env.map_knowledge(p).feat() == DNGN_UNSEEN)
+ if (in_bounds(p) &&
+ (beam.can_affect_wall(p) || env.map_knowledge(p).feat() == DNGN_UNSEEN))
{
possible_squares_affected++;
}
|
|
|
Relationships 
