Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0011839 [DCSS] Bug Report minor always 2019-01-22 07:35 2019-01-22 18:56
Reporter minmay View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Branch 0.23 old branch
Summary 0011839: Potion Petition ignores "no potion heal"
Description Curing and heal wounds from Potion Petition ignore the no potion heal mutation (and robe of Vines), giving their full healing amount even when the player should receive less or none.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0032959)
Stenella (reporter)
2019-01-22 18:56

This appears to be by design; it seems the original effect was renamed due to its effect, rather than its intention.

https://github.com/crawl/crawl/commit/303077ceedd3078c3bc0d2fb60e691a8e1447348 [^]

https://github.com/crawl/crawl/blob/master/crawl-ref/source/potion.cc#L1376 [^]
https://github.com/crawl/crawl/blob/master/crawl-ref/source/potion.cc#L190 [^]

are the relevant code paths. Potion-petition calls the effects with potion=false, while the check for nopotionheal is dependent on potion=true.

- Issue History
Date Modified Username Field Change
2019-01-22 07:35 minmay New Issue
2019-01-22 18:56 Stenella Note Added: 0032959


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker