|Anonymous | Login | Signup for a new account||2019-04-24 04:38 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0011306||[DCSS] Bug Report||text||always||2017-12-01 21:32||2019-02-01 20:44|
|Status||new||Product Branch||0.21 ancient branch|
|Summary||0011306: Trying to put on incompatible armour in forms results in unhelpful message of wrong item type.|
In Statue Form and other forms, putting on armour incompatible with that form results in
"That's the wrong kind of item!"
as if it is a potion or something that isn't armour.
It would be far more helpful to have this say:
"You can't wear that [at the moment]" or something similar.
|Tags||No tags attached.|
This is the result of the default behavior of the item select menu: if an item is not selectable by a given selector and you press its letter you get this generic message. If instead you use * to show all and then select the item you get a useful message.
A solution would be to add a reason return parameter to item_is_selected to contain a reason why an item wasn't selected. This probably is best done by refactoring the messaging from the verbose versions of can_wear/can_wield to require the caller to do the messaging instead, when desired. Doable, but a bit of work.
|2017-12-01 21:32||NormalPerson7||New Issue|
|2019-02-01 20:44||ebering||Note Added: 0033029|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|