|
Viewing Issue Simple Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Advanced ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0011009 |
[DCSS] Patches |
minor |
always |
2017-04-14 20:26 |
2018-01-30 04:01 |
|
|
Reporter |
cut1less |
View Status |
public |
|
|
Assigned To |
wheals |
|
Priority |
normal |
Resolution |
done |
|
|
Status |
resolved |
|
Product Branch |
0.21 ancient branch |
|
|
Summary |
0011009: map_colour() in source/feature.cc is unused, so magic-mapping colours are ignored in console |
|
Description |
For instance, if your option file has the line
feature += rock wall {,+,,cyan}
You'll get +'s for rock walls that have been magic-mapped, but you won't get a cyan color for those newly +'d rock walls in any view.
Looking into the code revealed that although map_colour() is defined, it's not actually called anywhere.
This patch adds two lines to source/showsymb.cc which seem to fix things.
|
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Attached Files |
 showsymb.patch [^] (450 bytes) 2017-04-14 20:26 [Show Content] [Hide Content]diff --git a/showsymb.cc b/showsymb.cc.new
index ad7b7e48c6..aff5f525fa 100644
--- a/showsymb.cc
+++ b/showsymb.cc.new
@@ -47,6 +47,8 @@ static unsigned short _cell_feat_show_colour(const map_cell& cell,
{
if (cell.flags & MAP_EMPHASIZE)
colour = fdef.seen_em_colour();
+ else if (cell.flags & MAP_MAGIC_MAPPED_FLAG)
+ colour = fdef.map_colour();
else
colour = fdef.seen_colour();
0001-Console-Use-magic-mapping-colors.patch [^] (924 bytes) 2017-04-15 08:05 [Show Content] [Hide Content]From 04142c49d999672af989cd113617ba1f2a953da9 Mon Sep 17 00:00:00 2001
From: cut1less <kazoon401@gmail.com>
Date: Sat, 15 Apr 2017 00:53:59 -0500
Subject: [PATCH] (Console) Use magic mapping colors
map_colour() exists but is not called anywhere. This adds a
magic-mapping section to where out-of-LOS elements get their color.
---
crawl-ref/source/showsymb.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/crawl-ref/source/showsymb.cc b/crawl-ref/source/showsymb.cc
index ad7b7e48c6..aff5f525fa 100644
--- a/crawl-ref/source/showsymb.cc
+++ b/crawl-ref/source/showsymb.cc
@@ -47,6 +47,8 @@ static unsigned short _cell_feat_show_colour(const map_cell& cell,
{
if (cell.flags & MAP_EMPHASIZE)
colour = fdef.seen_em_colour();
+ else if (cell.flags & MAP_MAGIC_MAPPED_FLAG)
+ colour = fdef.map_colour();
else
colour = fdef.seen_colour();
--
2.12.2
 before.png [^] (139,352 bytes) 2017-04-16 02:46
after.png [^] (139,415 bytes) 2017-04-16 02:46 |
|
|
