0010408: Player colour inscriptions can loose the surly bonds of {}

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0010408

[DCSS] Bug Report

minor

always

2016-05-09 18:28

2017-02-06 20:38

Reporter

PleasingFungus

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Branch

0.19 ancient branch

Summary

0010408: Player colour inscriptions can loose the surly bonds of {}

Description

Colour tags in inscriptions will be rendered in most contexts; e.g., inscribing "<red>foo</red>" will produce red-coloured text. The trouble comes when one skips closing tags, as in "<red>foo". In this case, the closing brace of the inscription will be coloured when on the inventory screen, and when examining the item itself, the closing brace AND everything after (the entire description) will be coloured. This seems incorrect.

One option would be to sanitize colour tags out of player-provided inscriptions. I've created a branch, sanitize_inscripts, that does this. However, it seems a pity to shut down something that is fun for players just because of cosmetic issues - surely there's *some* better way to solve this problem, some pre-processing on inscription text...?

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0030555) PleasingFungus (administrator) 2016-05-27 21:08	There are similar issues with the 'pizza' rcfile option.

(0031472) PleasingFungus (administrator) 2017-02-06 20:38	The pizza rcfile option is, tragically, no more.

Issue History
Date Modified	Username	Field	Change
2016-05-09 18:28	PleasingFungus	New Issue
2016-05-10 07:44	user6120	Issue Monitored: user6120
2016-05-10 07:45	user6120	Note Added: 0030455
2016-05-10 07:46	user6120	Note Deleted: 0030455
2016-05-10 07:46	user6120	Note Added: 0030456
2016-05-10 08:00	PleasingFungus	Note Deleted: 0030456
2016-05-27 21:08	PleasingFungus	Note Added: 0030555
2017-02-06 20:38	PleasingFungus	Note Added: 0031472

Mantis 1.1.8[^]