|Anonymous | Login | Signup for a new account||2019-08-19 16:36 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0010333||[DCSS] Bug Report||minor||always||2016-03-27 06:12||2016-03-27 07:14|
|Status||closed||Product Branch||0.18 ancient branch|
|Summary||0010333: Speed brand is a bit broken by integer math|
Caused by 2733cf4, if I'm reading this correctly.
That commit sets int weapon_min_delay in fight.cc to (min_delay*2/3) if the weapon has speed brand. Since this is integer math, this means min_delay is always an integer. E.g., this sets min_delay to 4 for a longbow of speed.
The problem is that speed brand isn't supposed to work this way; weapon_min_delay (the way it is used now) is actually supposed to be noninteger (4.7 for longbow of speed for example).
The result is that a longbow of speed does have the 0.4 min delay that the game claims (this claim is supposed to be a bit of a lie, if you read the commit message for 2733cf4), but reaches this delay at skill 22, not skill 20.
So speed brand once again actually changes the skill for min delay for many weapons (and is particularly good for weapons with specific non-speed weapon_min_delay), which of course is amusing because avoiding this is one of the reasons the brand was changed in the first place.
|Tags||No tags attached.|
|edit: weapon_min_delay being an integer is perfectly fine for all non-speed weapons, of course.|
|Fixed in trunk (0.18-a0-1640-g8b6524e), thanks!|
|2016-03-27 06:12||crate||New Issue|
|2016-03-27 06:16||crate||Note Added: 0030311|
|2016-03-27 07:07||neil||Note Added: 0030312|
|2016-03-27 07:07||neil||Status||new => resolved|
|2016-03-27 07:07||neil||Fixed in Branch||=> 0.18 development branch|
|2016-03-27 07:07||neil||Resolution||open => done|
|2016-03-27 07:07||neil||Assigned To||=> neil|
|2016-03-27 07:14||crate||Status||resolved => closed|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|