0010318: Webtiles input hangs when a spectator joins, if the player is currently inputting a !note at the time of spectator join.

(0030304)
MrPlanck (reporter)
2016-03-18 19:45

This has happened to me twice in the past few days on CSZO.

(0030439)
PleasingFungus (administrator)
2016-05-05 07:20

This also occurs while the player is using other text input fields; e.g. stash search.

(0031168)
PleasingFungus (administrator)
2016-10-22 07:50

I'm unable to reproduce this locally.

(0031625)
advil (administrator)
2017-04-28 03:16
edited on: 2017-04-28 03:18

This should be fixed in https://github.com/crawl/crawl/commit/127e8e2b14b2 [^] . It was triggered by a resize/re-layout, which sometimes but not always happens when a spectator joins (I'm not sure of the exact conditions). I'll leave this open for a few days because I'm less sure about the conditions for this vs 0010938, but it doesn't happen any more in my local testing and should be the same cause as that bug.

(0031628)
Leszczynek (reporter)
2017-04-29 01:17

The main issue of the game hanging up is fixed, but there seems to be a tiny bug remaining. When a spectator joins when the player is in the middle of writing the note, he needs to refocus the note textbox manually, and when he finishes writing, only the part that existed before spectator joined will be saved to notes.

Noticed on up-to-date Firefox (53.0).

(0031629)
advil (administrator)
2017-04-29 16:25
edited on: 2017-04-29 16:33

Thanks for pointing that out, I think I've fixed this problem (plus refocusing) in https://github.com/crawl/crawl/commit/70c76d283416 [^] . Still gonna leave this open for a bit.

(0032114)
MrPlanck (reporter)
2018-03-09 00:19
edited on: 2018-03-09 00:20

A similar issue can occur when a webtiles window (e.g,. inventory, search...etc) is open and a spectator joins. The window does not close.

(0032185)
advil (administrator)
2018-04-23 04:01

The text input bug seems to be long gone, so I'm closing this up. There's a separate open bug for the menu thing as 0011387 - behavior-wise it's similar, but the root cause seems to be fairly different.

Issue History
Date Modified	Username	Field	Change
2016-03-13 19:19	Implojin	New Issue
2016-03-18 19:45	MrPlanck	Note Added: 0030304
2016-05-05 07:20	PleasingFungus	Note Added: 0030439
2016-10-22 07:50	PleasingFungus	Note Added: 0031168
2016-11-05 16:43	PleasingFungus	Relationship added	has duplicate 0010764
2017-04-28 03:16	advil	Note Added: 0031625
2017-04-28 03:17	advil	Relationship added	related to 0010938
2017-04-28 03:17	advil	Note Edited: 0031625
2017-04-28 03:17	advil	Note Edited: 0031625
2017-04-28 03:18	advil	Note Edited: 0031625
2017-04-29 01:17	Leszczynek	Note Added: 0031628
2017-04-29 16:25	advil	Note Added: 0031629
2017-04-29 16:33	advil	Note Edited: 0031629
2018-03-09 00:19	MrPlanck	Note Added: 0032114
2018-03-09 00:20	MrPlanck	Note Edited: 0032114
2018-04-23 03:59	advil	Relationship added	related to 0011387
2018-04-23 04:01	advil	Note Added: 0032185
2018-04-23 04:01	advil	Status	new => resolved
2018-04-23 04:01	advil	Fixed in Branch	=> 0.20 old branch
2018-04-23 04:01	advil	Resolution	open => done
2018-04-23 04:01	advil	Assigned To	=> advil

Notes
(0030304) MrPlanck (reporter) 2016-03-18 19:45	This has happened to me twice in the past few days on CSZO.

(0030439) PleasingFungus (administrator) 2016-05-05 07:20	This also occurs while the player is using other text input fields; e.g. stash search.

(0031168) PleasingFungus (administrator) 2016-10-22 07:50	I'm unable to reproduce this locally.

(0031625) advil (administrator) 2017-04-28 03:16 edited on: 2017-04-28 03:18	This should be fixed in https://github.com/crawl/crawl/commit/127e8e2b14b2 [^] . It was triggered by a resize/re-layout, which sometimes but not always happens when a spectator joins (I'm not sure of the exact conditions). I'll leave this open for a few days because I'm less sure about the conditions for this vs 0010938, but it doesn't happen any more in my local testing and should be the same cause as that bug.

(0031628) Leszczynek (reporter) 2017-04-29 01:17	The main issue of the game hanging up is fixed, but there seems to be a tiny bug remaining. When a spectator joins when the player is in the middle of writing the note, he needs to refocus the note textbox manually, and when he finishes writing, only the part that existed before spectator joined will be saved to notes. Noticed on up-to-date Firefox (53.0).

(0031629) advil (administrator) 2017-04-29 16:25 edited on: 2017-04-29 16:33	Thanks for pointing that out, I think I've fixed this problem (plus refocusing) in https://github.com/crawl/crawl/commit/70c76d283416 [^] . Still gonna leave this open for a bit.

(0032114) MrPlanck (reporter) 2018-03-09 00:19 edited on: 2018-03-09 00:20	A similar issue can occur when a webtiles window (e.g,. inventory, search...etc) is open and a spectator joins. The window does not close.

(0032185) advil (administrator) 2018-04-23 04:01	The text input bug seems to be long gone, so I'm closing this up. There's a separate open bug for the menu thing as 0011387 - behavior-wise it's similar, but the root cause seems to be fairly different.