Dungeon Crawl Stone Soup Tracker - DCSS
|
Viewing Issue Advanced Details |
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
8557 |
Bug Report |
minor |
always |
2014-05-15 03:07 |
2014-05-15 04:51 |
|
Reporter:
|
PleasingFungus |
Local or Remote:
|
Both |
|
Assigned To:
|
Reaver |
Operating System:
|
All |
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
Status:
|
resolved |
Product Branch:
|
0.15 ancient branch |
|
Product Version:
|
0.15-a0-844-g0deed4f |
Resolution:
|
done |
|
Projection:
|
none |
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.15 ancient branch |
|
|
Summary:
|
0008557: Merged slime creatures are worth less XP than individual slime creatures |
Description:
|
Slime creatures are supposed to be worth the same XP no matter what configuration you kill them in: individually, merged into titanic slime creature, or somewhere in between. This is to discourage pathological player behavior for maximizing XP gains.
At present, this more-or-less works for some configurations, but fails for sufficiently large (enormous/titanic) slime creatures; they're worth Note: 0000825 and Note: 0000900 XP respectively, compared to the (250*4=1000) and (250*5=1250) XP respectively they'd be worth if their composing slimelets were killed separately.
Attached is a fix. |
Steps To Reproduce:
|
|
Additional Information:
|
|
System Description:
|
|
Relationships | |
Attached Files:
|
0001-Fix-slimes-being-worth-less-XP-when-merged.patch [^] (1,509 bytes) 2014-05-15 03:07 [Show Content] [Hide Content]From e35684648a9339dda9e4e28974c0f446809639c7 Mon Sep 17 00:00:00 2001
From: Nicholas Feinberg <pleasingfung@gmail.com>
Date: Wed, 14 May 2014 17:51:06 -0700
Subject: [PATCH] Fix slimes being worth less XP when merged
---
crawl-ref/source/mon-util.cc | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/crawl-ref/source/mon-util.cc b/crawl-ref/source/mon-util.cc
index a4f3d7c..6ddaeab 100644
--- a/crawl-ref/source/mon-util.cc
+++ b/crawl-ref/source/mon-util.cc
@@ -2152,11 +2152,6 @@ int exper_value(const monster* mon, bool real)
x_val /= 10;
}
- // Slime creature exp hack part 2: Scale exp back up by the number
- // of blobs merged. -cao
- if (mon->type == MONS_SLIME_CREATURE && mon->number > 1)
- x_val *= mon->number;
-
// Scale starcursed mass exp by what percentage of the whole it represents
if (mon->type == MONS_STARCURSED_MASS)
x_val = (x_val * mon->number) / 12;
@@ -2171,6 +2166,13 @@ int exper_value(const monster* mon, bool real)
if (x_val > 750)
x_val = 750 + (x_val - 750) / 3;
+ // Slime creature exp hack part 2: Scale exp back up by the number
+ // of blobs merged. -cao
+ // Has to be after the stepdown to prevent issues with 4-5 merged slime
+ // creatures. -pf
+ if (mon->type == MONS_SLIME_CREATURE && mon->number > 1)
+ x_val *= mon->number;
+
// Guarantee the value is within limits.
if (x_val <= 0)
x_val = 1;
--
1.8.5.2 (Apple Git-48)
|
|
Issue History |
Date Modified |
Username |
Field |
Change |
2014-05-15 03:07 |
PleasingFungus |
New Issue |
|
2014-05-15 03:07 |
PleasingFungus |
File Added: 0001-Fix-slimes-being-worth-less-XP-when-merged.patch |
|
2014-05-15 03:13 |
PleasingFungus |
Note Added: 0026173 |
|
2014-05-15 04:51 |
Reaver |
Note Added: 0026175 |
|
2014-05-15 04:51 |
Reaver |
Status |
new => resolved |
2014-05-15 04:51 |
Reaver |
Fixed in Branch |
=> 0.15 development branch |
2014-05-15 04:51 |
Reaver |
Resolution |
open => done |
2014-05-15 04:51 |
Reaver |
Assigned To |
=> Reaver |