Dungeon Crawl Stone Soup Tracker - DCSS
|
Viewing Issue Advanced Details |
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
7635 |
Patches |
tweak |
N/A |
2013-10-15 15:34 |
2013-10-23 17:57 |
|
Reporter:
|
Whales |
Local or Remote:
|
Both |
|
Assigned To:
|
Kate |
Operating System:
|
All |
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
Status:
|
resolved |
Product Branch:
|
0.14 ancient branch |
|
Product Version:
|
0.14-a0-262-gc3caa5d |
Resolution:
|
done |
|
Projection:
|
none |
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.14 ancient branch |
|
|
Summary:
|
0007635: Jump attacks don't fumble |
Description:
|
It doesn't make sense to me that a jump attack can fumble if the landing site is shallow water. I envisioned it as a mid-air attack rather than land, then attack.
This is my first patch submission, albeit a very simple one, but it still might be better to treat this as a feature request rather than a proper patch ;) |
Steps To Reproduce:
|
|
Additional Information:
|
|
System Description:
|
|
Relationships | |
Attached Files:
|
no_jump_fumble.patch [^] (420 bytes) 2013-10-15 15:34 [Show Content] [Hide Content]--- melee_attack.cc 2013-10-15 08:28:31.622140941 -0500
+++ melee_attack_n.cc 2013-10-15 08:28:22.092141602 -0500
@@ -387,7 +387,7 @@
attacker->make_hungry(3, true);
// Xom thinks fumbles are funny...
- if (attacker->fumbles_attack())
+ if (!jumping_attack && attacker->fumbles_attack())
{
// ... and thinks fumbling when trying to hit yourself is just
// hilarious.
|
|
Issue History |
Date Modified |
Username |
Field |
Change |
2013-10-15 15:34 |
Whales |
New Issue |
|
2013-10-15 15:34 |
Whales |
File Added: no_jump_fumble.patch |
|
2013-10-23 17:57 |
Kate |
Note Added: 0024240 |
|
2013-10-23 17:57 |
Kate |
Status |
new => resolved |
2013-10-23 17:57 |
Kate |
Fixed in Branch |
=> 0.14 development branch |
2013-10-23 17:57 |
Kate |
Resolution |
open => done |
2013-10-23 17:57 |
Kate |
Assigned To |
=> Kate |