Dungeon Crawl Stone Soup Tracker - DCSS
|
Viewing Issue Advanced Details |
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
7603 |
Bug Report |
minor |
have not tried |
2013-10-04 17:33 |
2013-10-05 01:10 |
|
Reporter:
|
magicpoints |
Local or Remote:
|
Both |
|
Assigned To:
|
neil |
Operating System:
|
All |
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
Status:
|
resolved |
Product Branch:
|
0.14 ancient branch |
|
Product Version:
|
0.14-a0-155-gd989017 |
Resolution:
|
done |
|
Projection:
|
none |
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.14 ancient branch |
|
|
Summary:
|
0007603: Spammy messages when fighting in water in trunk |
Description:
|
In trunk 0.14-a0-155-gd989017 on CSZO, the game prints "Splash! You fall into the shallow water. Moving in this stuff is going to be slow." every time you melee attack while in water. This is probably related to jump, like the out-of-range bug from the other day.
(Splash! You fall into the shallow water. Moving in this stuff is going to be slow.) |
Steps To Reproduce:
|
|
Additional Information:
|
|
System Description:
|
|
Relationships | |
Attached Files:
|
0001-Stop-spammy-messages-from-melee-attacks-in-water.patch [^] (970 bytes) 2013-10-04 20:50 [Show Content] [Hide Content]From 1cb1cbca4036bee55f23a761f2ec00fff64af664 Mon Sep 17 00:00:00 2001
From: BlackSheep <chris.terenzi@gmail.com>
Date: Fri, 4 Oct 2013 14:48:11 -0400
Subject: [PATCH] Stop spammy messages from melee attacks in water
---
crawl-ref/source/melee_attack.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/crawl-ref/source/melee_attack.cc b/crawl-ref/source/melee_attack.cc
index 01ce070..8e62ae1 100644
--- a/crawl-ref/source/melee_attack.cc
+++ b/crawl-ref/source/melee_attack.cc
@@ -318,8 +318,9 @@ bool melee_attack::handle_phase_attempted()
mpr("There is nothing there, so you fail to move!");
return false;
}
+ move_player_to_grid(attack_position, false, true);
}
- move_player_to_grid(attack_position, false, true);
+
// Set delay now that we know the attack won't be cancelled.
you.time_taken = calc_attack_delay();
if (weapon)
--
1.8.1.2
|
|
Issue History |
Date Modified |
Username |
Field |
Change |
2013-10-04 17:33 |
magicpoints |
New Issue |
|
2013-10-04 20:50 |
BlackSheep |
File Added: 0001-Stop-spammy-messages-from-melee-attacks-in-water.patch |
|
2013-10-04 20:50 |
BlackSheep |
Note Added: 0024154 |
|
2013-10-05 01:10 |
neil |
Note Added: 0024155 |
|
2013-10-05 01:10 |
neil |
Status |
new => resolved |
2013-10-05 01:10 |
neil |
Fixed in Branch |
=> 0.14 development branch |
2013-10-05 01:10 |
neil |
Resolution |
open => done |
2013-10-05 01:10 |
neil |
Assigned To |
=> neil |