|
Dungeon Crawl Stone Soup Tracker - DCSS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
7492 |
Bug Report |
minor |
always |
2013-08-20 08:48 |
2013-08-20 22:48 |
|
|
Reporter:
|
Zannick |
Local or Remote:
|
Both |
|
|
Assigned To:
|
galehar |
Operating System:
|
All |
|
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
|
Status:
|
resolved |
Product Branch:
|
0.13 ancient branch |
|
|
Product Version:
|
|
Resolution:
|
done |
|
|
Projection:
|
none |
|
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.13 ancient branch |
|
|
|
Summary:
|
0007492: Arena crash due to contamination checking. |
|
Description:
|
Running the arena from trunk causes an assert failure.
Root cause is c56f7848 which moves the contamination handling in handle_time() to above the point where the arena returns early. Simple fix attached which adds another check whether this is sparta^W arena. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
|
System Description:
|
|
| Relationships | |
|
Attached Files:
|
 0001-Don-t-contaminate-the-arena.patch [^] (853 bytes) 2013-08-20 08:48 [Show Content] [Hide Content]From c0e59602492d144950a4017ebc3d9635a0b6c5fd Mon Sep 17 00:00:00 2001
From: Zannick <jokeserver@gmail.com>
Date: Mon, 19 Aug 2013 23:41:46 -0700
Subject: [PATCH] Don't contaminate the arena.
Fixes arena crash caused by c56f7848.
---
crawl-ref/source/effects.cc | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/crawl-ref/source/effects.cc b/crawl-ref/source/effects.cc
index 0cbe682..d8b0bbc 100644
--- a/crawl-ref/source/effects.cc
+++ b/crawl-ref/source/effects.cc
@@ -2211,7 +2211,8 @@ void handle_time()
forget_map(true);
// Magic contamination from spells and Orb.
- _handle_magic_contamination();
+ if (!crawl_state.game_is_arena())
+ _handle_magic_contamination();
// Every 20 turns, a variety of other effects.
if (! (_div(base_time, 200) > _div(old_time, 200)))
--
1.7.4.4
|
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2013-08-20 08:48 |
Zannick |
New Issue |
|
|
2013-08-20 08:48 |
Zannick |
File Added: 0001-Don-t-contaminate-the-arena.patch |
|
|
2013-08-20 22:48 |
galehar |
Note Added: 0023798 |
|
|
2013-08-20 22:48 |
galehar |
Status |
new => resolved |
|
2013-08-20 22:48 |
galehar |
Fixed in Branch |
=> 0.13 development branch |
|
2013-08-20 22:48 |
galehar |
Resolution |
open => done |
|
2013-08-20 22:48 |
galehar |
Assigned To |
=> galehar |