Dungeon Crawl Stone Soup Tracker - DCSS
|
Viewing Issue Advanced Details |
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
7312 |
Patches |
minor |
N/A |
2013-07-05 18:24 |
2013-08-25 01:08 |
|
Reporter:
|
pubby |
Local or Remote:
|
Both |
|
Assigned To:
|
KiloByte |
Operating System:
|
All |
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
Status:
|
resolved |
Product Branch:
|
0.13 ancient branch |
|
Product Version:
|
|
Resolution:
|
done |
|
Projection:
|
none |
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.13 ancient branch |
|
|
Summary:
|
0007312: Fix do_shaft: allow it to work anywhere. |
Description:
|
I found this bug while coding dwants/formicids, and figured I should submit it separately in case they never make it into trunk :(
It fixes shafting to actually work when not standing over a trap, for instance from chaos brand. For monsters this was being properly handled. |
Steps To Reproduce:
|
|
Additional Information:
|
|
System Description:
|
|
Relationships | |
Attached Files:
|
0001-Fix-do_shaft-allow-it-to-work-anywhere.patch [^] (1,180 bytes) 2013-07-05 18:24 [Show Content] [Hide Content]From 108f2071bafbae428c9dfc9b1b6e980344214ca3 Mon Sep 17 00:00:00 2001
From: pubby <pubby8@gmail.com>
Date: Fri, 5 Jul 2013 11:02:31 -0500
Subject: [PATCH] Fix do_shaft: allow it to work anywhere.
A bug in down_stairs was preventing players from getting shafted when
not standing over a shaft trap (such as from chaos brand). This function had an
option for players to get shafted this way, but it wasn't being properly
checked in the function body.
---
crawl-ref/source/stairs.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crawl-ref/source/stairs.cc b/crawl-ref/source/stairs.cc
index 3195801..205e9d7 100644
--- a/crawl-ref/source/stairs.cc
+++ b/crawl-ref/source/stairs.cc
@@ -668,8 +668,8 @@ void down_stairs(dungeon_feature_type force_stair)
}
// Only check the current position for a legal stair traverse.
- // If it's a known shaft that we're taking, then we're already good.
- if (!known_shaft && !_check_stairs(stair_find, true))
+ // If it's a shaft that we're taking, then we're already good.
+ if (!shaft && !_check_stairs(stair_find, true))
return;
if (_stair_moves_pre(stair_find))
--
1.8.2.3
|
|
Issue History |
Date Modified |
Username |
Field |
Change |
2013-07-05 18:24 |
pubby |
New Issue |
|
2013-07-05 18:24 |
pubby |
File Added: 0001-Fix-do_shaft-allow-it-to-work-anywhere.patch |
|
2013-08-05 18:04 |
Kate |
Issue Monitored: Kate |
|
2013-08-25 01:08 |
KiloByte |
Note Added: 0023864 |
|
2013-08-25 01:08 |
KiloByte |
Status |
new => resolved |
2013-08-25 01:08 |
KiloByte |
Fixed in Branch |
=> 0.13 development branch |
2013-08-25 01:08 |
KiloByte |
Resolution |
open => done |
2013-08-25 01:08 |
KiloByte |
Assigned To |
=> KiloByte |
2013-08-27 19:55 |
Kate |
Issue End Monitor: Kate |
|