|
Dungeon Crawl Stone Soup Tracker - DCSS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
7302 |
Patches |
major |
random |
2013-07-04 00:42 |
2013-07-04 02:58 |
|
|
Reporter:
|
Zannick |
Local or Remote:
|
Both |
|
|
Assigned To:
|
KiloByte |
Operating System:
|
All |
|
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
|
Status:
|
resolved |
Product Branch:
|
0.13 ancient branch |
|
|
Product Version:
|
|
Resolution:
|
done |
|
|
Projection:
|
none |
|
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.13 ancient branch |
|
|
|
Summary:
|
0007302: monster::reset leaves uninitialized memory in spells |
|
Description:
|
This bug has surfaced due to http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=e5352be0157e [^] stopping empty spell lists from being marshalled/unmarshalled.
Basically, monster::monster() creates a monster_spells FixedVector with uninitialized memory, and monster::reset() does not clear it (though monster::init_with() does). Since unmarshalling calls only reset(), the spells list remains uninitialized. The end result is that monsters that did not have any spells now have effectively random spell lists after loading saves.
This patch should clear the spell list in monster::init(), alleviating the issue. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
|
System Description:
|
|
| Relationships | |
|
Attached Files:
|
 0001-Clear-the-spell-list-on-monster-init.patch [^] (681 bytes) 2013-07-04 00:42 [Show Content] [Hide Content]From 0305a85e676e2949d721d6869b3ddb55c6cd3d30 Mon Sep 17 00:00:00 2001
From: Zannick <jokeserver@gmail.com>
Date: Wed, 3 Jul 2013 15:37:29 -0700
Subject: [PATCH] Clear the spell list on monster init.
---
crawl-ref/source/monster.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/crawl-ref/source/monster.cc b/crawl-ref/source/monster.cc
index 2a9fb9b..91aea96 100644
--- a/crawl-ref/source/monster.cc
+++ b/crawl-ref/source/monster.cc
@@ -109,6 +109,7 @@ void monster::reset()
ench_cache.reset();
ench_countdown = 0;
inv.init(NON_ITEM);
+ spells.init(SPELL_NO_SPELL);
flags = 0;
experience = 0;
--
1.7.4.4
|
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2013-07-04 00:42 |
Zannick |
New Issue |
|
|
2013-07-04 00:42 |
Zannick |
File Added: 0001-Clear-the-spell-list-on-monster-init.patch |
|
|
2013-07-04 02:58 |
KiloByte |
Note Added: 0023385 |
|
|
2013-07-04 02:58 |
KiloByte |
Status |
new => resolved |
|
2013-07-04 02:58 |
KiloByte |
Fixed in Branch |
=> 0.13 development branch |
|
2013-07-04 02:58 |
KiloByte |
Resolution |
open => done |
|
2013-07-04 02:58 |
KiloByte |
Assigned To |
=> KiloByte |