Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details
7247 Patches feature N/A 2013-06-23 14:14 2014-01-26 22:45
pubby Both  
KiloByte All  
normal Both  
resolved 0.13 ancient branch  
done  
none    
none 0.14 ancient branch  
0007247: 4 new artefacts (no tiles)
Trog's Gloves:
Trog's hand in glove form. It gives your UC an antimagic brand.

Moon troll leather armour:
Double regen branded with spirit shield.

Boots of Ultimate Suction:
Let's you cling to walls and provides trample resistance.

Macabre Finger Necklace: (the best of the bunch)
A warding amulet that provides you with another ring slot.
? file icon pubby_unrandarts.patch [^] (35,617 bytes) 2013-06-23 14:14 [Show Content]
? file icon pubby_unrandarts2.patch [^] (37,484 bytes) 2013-06-24 04:06 [Show Content]
? file icon 0001-Change-Trog-s-Gloves-to-antimagic-while-berserk.patch [^] (2,162 bytes) 2013-09-01 23:18 [Show Content]
? file icon 0002-Fix-Rename-boots-of-suction-into-boots-of-bonding.patch [^] (3,496 bytes) 2013-09-01 23:18 [Show Content]
Issue History
2013-06-23 14:14 pubby New Issue
2013-06-23 14:14 pubby File Added: pubby_unrandarts.patch
2013-06-23 15:40 pubby Note Added: 0023272
2013-06-24 04:06 pubby File Added: pubby_unrandarts2.patch
2013-06-24 16:43 mumra Note Added: 0023279
2013-06-24 16:43 mumra Note Edited: 0023279
2013-06-24 18:54 dpeg Note Added: 0023284
2013-06-24 19:28 mumra Note Added: 0023285
2013-06-25 03:59 pubby Note Added: 0023290
2013-06-25 04:00 pubby Note Edited: 0023290
2013-08-28 01:06 KiloByte Note Added: 0023886
2013-08-29 07:20 neil Note Added: 0023916
2013-08-29 07:20 neil Note Edited: 0023916
2013-08-29 08:15 pubby Note Added: 0023918
2013-08-29 11:44 KiloByte Note Added: 0023923
2013-08-29 15:35 KiloByte Note Added: 0023927
2013-08-29 20:49 evilmike Note Added: 0023930
2013-09-01 23:18 pubby File Added: 0001-Change-Trog-s-Gloves-to-antimagic-while-berserk.patch
2013-09-01 23:18 pubby File Added: 0002-Fix-Rename-boots-of-suction-into-boots-of-bonding.patch
2013-09-02 01:10 KiloByte Note Added: 0023961
2013-09-22 22:25 KiloByte Note Added: 0024066
2013-09-23 22:42 MarvinPA Note Added: 0024082
2014-01-26 22:44 KiloByte Note Added: 0025102
2014-01-26 22:44 KiloByte Status new => resolved
2014-01-26 22:44 KiloByte Fixed in Branch => 0.14 development branch
2014-01-26 22:44 KiloByte Resolution open => done
2014-01-26 22:44 KiloByte Assigned To => KiloByte

Notes
(0023272)
pubby   
2013-06-23 15:40   
I realized that I didn't properly handle cursed gloves interacting with rings. I wrote a fix, but I'll wait til tomorrow to post an updated patch.
(0023279)
mumra   
2013-06-24 16:43   
Trog's Gloves:
Can't really comment on this, might be interesting; popular opinion is generally that UC doesn't need any buffs (at least this is the usual comment to suggestions for e.g. spiked knuckles).

Moon troll armour:
Silly name, way overpowered.

Boots of Ultimate Suction:
Also a silly name, the effect might be ok, it's at least not as OP as boots of running. I'd suggest something along the lines of "Boots of the Spider", "Boots of the Arachnid" or just "Boots of Clinging" for the name. Boring, I know, but the idea of suction cups on the feet is heavily anachronistic.

Macabre Finger Necklace:
If god meant for us to wear rings around our necks why did he give us fingers.
Also see my comments about the same idea in this thread: https://crawl.develz.org/tavern/viewtopic.php?f=8&t=7579&p=102403#p102403 [^]

(0023284)
dpeg   
2013-06-24 18:54   
I don't think these unrandarts are too strong.

Giving UC a strong brand does seem questionable, though.

The boots have an unacceptable name, as mumra pointed out. The effect seems interesting enough to me.

A quick ##crawl-dev discussion on the amulet-ring showed disagreement: mumra argued it's too strong, kilobyte argued it's too weak, I say it's probably okay. kilobyte mentioned that code complexity may be too much -- since I would really like something similar for random gods (additional divine ring fingers), I am all for having this unrandart.

pubby: Regardless what comes out of this, many thanks!
(0023285)
mumra   
2013-06-24 19:28   
I think I was misjudging the relative strengths of amulets and rings; I'm still not sure how interesting the decision offered by the amulet is ... making decisions meaningful is very often about restricting options rather than making too many available. Still, I am sitting on the fence on this. The flavour does have a nice macabre quality.

The armour regen isn't as strong as I originally thought, so maybe that's ok (Moon Troll might still be a bad name though, this was originally an obscure joke I believe)
(0023290)
pubby   
2013-06-25 03:59   
(edited on: 2013-06-25 04:00)
> kilobyte mentioned that code complexity may be too much

I think I actually reduced the code complexity. The original ring code was duplicated to handle Octopodes with functions with names like _puton_ring_octopode. I moved everything into single functions which could handle any amount of ring slots. item_use.cc was actually reduced in LOC.

(0023886)
KiloByte   
2013-08-28 01:06   
I've split the patch into four commits (to make it easier to review) and pushed to a branch "buppy_arts".

What now? Obviously, the name of Ultimate Suction sucks (apt!), so this needs to be renamed.
(0023916)
neil   
2013-08-29 07:20   
Boots of tenacity? Tackety boots? Boots of the hobnail?

(0023918)
pubby   
2013-08-29 08:15   
Gelatinous galoshes? Clingy clogs? Sticky sandals?

I'll fix these artefacts and resubmit.
(0023923)
KiloByte   
2013-08-29 11:44   
Because of the description, I like mumra's naming suggestions. They also match the primary visible function: trample has hardly any practical effect.

þuþþy: could you please either base your edits on split commits I pushed to gitorious, or alternatively as additional commits atop of them (or your original monolithic patch, they're identical except for rebasing onto current trunk)?
(0023927)
KiloByte   
2013-08-29 15:35   
There's a question which of the artefacts should go in, too.

The boots are worse than ordinary boots of flying (trample resistance is, I'd say worse than benefits from flying over clinging). An underpowered unrand is not necessarily bad, though.

The ring amulet could go in, especially considering dpeg's request for divine slots.

I'd vote +1 to moon troll leather.

Trog's gloves... I like them somewhat less, but with no other input I'd commit them.
(0023930)
evilmike   
2013-08-29 20:49   
I don't think any of these artifacts are worth adding except for the armour one.

The boots aren't just an underpowered artefact, they are worse than one of the standard boot egos, which makes them pretty dull in my opinion.

I don't like the amulet because I don't think players should be allowed to get more than two ring slots (except MAYBE from whatever randgod stuff is being worked on). My objection isn't to do with power, it's more that I prefer equipment slots to be an intrinsic thing, only changable by mutations. I don't like the idea that you can gain/lose a slot at will like that.

The gloves just seem very limited to me. Crawl has a lot of artefacts with a small niche, but these in particular require you to be unarmed, not using spells (especially transmutations), not a be troll or other race that is blocked from using gloves, and actually find the artefact.
(0023961)
KiloByte   
2013-09-02 01:10   
Mooner is in.
(0024066)
KiloByte   
2013-09-22 22:25   
The finger necklace is in, in [next].

Do we want the rest?
(0024082)
MarvinPA   
2013-09-23 22:42   
I'm with evilmike on the boots, they look very underwhelming.

No idea on the gloves, they look better than before with the most recent patch but I'm not that keen on how closely they're tied to a single god ability.
(0025102)
KiloByte   
2014-01-26 22:44   
3/4 in, I think it's closing time.