Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details
6306 Bug Report major always 2012-10-12 10:21 2013-03-06 13:07
Medar Remote  
edlothiol CSZO  
normal WebTiles  
closed 0.11 ancient branch  
0.11.0 done  
none    
none 0.12 ancient branch  
0006306: WebTiles: Long menus with repeating letters lead to wrong item being selected sometimes
On WebTiles, when there is a long menu where the letters are repeated, it sometimes picks the item that is off screen instead of the item on screen with the same letter.

This seems to happen always when page down is pressed an extra time, when the menu is already at the bottom.
? file icon 0002-Check-WebTiles-menu-indices-after-each-scroll.patch [^] (2,144 bytes) 2013-03-02 12:38 [Show Content]
? file icon 0005-Hide-WebTiles-dialogs-when-the-connection-is-closed.patch [^] (876 bytes) 2013-03-02 12:39 [Show Content]
? file icon 0006-Make-sure-new-menus-are-scrolled-to-the-top-in-WebTi.patch [^] (1,295 bytes) 2013-03-02 12:39 [Show Content]
? file icon 0007-Make-sure-to-send-menu_scroll-before-selection-in-We.patch [^] (2,791 bytes) 2013-03-02 12:39 [Show Content]
Issue History
2012-10-12 10:21 Medar New Issue
2013-03-02 12:38 Medar File Added: 0002-Check-WebTiles-menu-indices-after-each-scroll.patch
2013-03-02 12:39 Medar File Added: 0005-Hide-WebTiles-dialogs-when-the-connection-is-closed.patch
2013-03-02 12:39 Medar File Added: 0006-Make-sure-new-menus-are-scrolled-to-the-top-in-WebTi.patch
2013-03-02 12:39 Medar File Added: 0007-Make-sure-to-send-menu_scroll-before-selection-in-We.patch
2013-03-02 12:48 Medar Note Added: 0021228
2013-03-05 20:53 edlothiol Note Added: 0021267
2013-03-05 20:53 edlothiol Status new => resolved
2013-03-05 20:53 edlothiol Fixed in Branch => 0.12 development branch
2013-03-05 20:53 edlothiol Resolution open => done
2013-03-05 20:53 edlothiol Assigned To => edlothiol
2013-03-06 13:07 Medar Status resolved => closed

Notes
(0021228)
Medar   
2013-03-02 12:48   
Added patches:

0002: Checks the menu indices after each scroll, fixes this bug by no longer messing up indices while scrolling while already at the end/start.

0005: Just a tiny fix to hide dialogs in the case websocket connection is closed.

0006: In Firefox (not Chrome) menu scrolling position is remembered between menus (even different ones). This fixes that.

0007: menu_scroll event is send on a timer, unfortunately this means that if you do your selection right after scrolling the server has a wrong view on what's being selected. This patch sends the menu_scroll update (if necessary) on every keypress/keydown that is not handled by the client side menu code.

As these fixes are all related (and pretty small), so I opted to post them all here instead of opening new bugs. Let me know if in future you prefer multiple reports, or something else.
(0021267)
edlothiol   
2013-03-05 20:53   
Thanks, they're applied. For cases like this, I think adding the patches to the same issue is fine.