Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details
603 Source Cleanup minor have not tried 2010-01-29 14:20 2015-04-14 18:31
rob  
Kate  
normal  
closed  
done  
none    
none 0.16 ancient branch  
0000603: monster speed cleanup
A lot of magic numbers and pre-stonesoup weirdness in there.

In particular, base speed_increment is 70, minimum speed_increment to act is 80. One of these should be around 0.

There's weird code with monsters::speed over 100 being used as a flag (see ENCH_HASTE). speed>=100 is checked once without comment in the main monster energy loop. This should probably be removed.

monsters::fix_speed and monsters::check_speed may not be required anymore.

speed_increment needs a better name, e.g. available_energy.
Issue History
2010-01-29 14:20 rob New Issue
2010-01-29 14:21 rob Description Updated
2015-04-14 18:31 Kate Note Added: 0028860
2015-04-14 18:31 Kate Status new => resolved
2015-04-14 18:31 Kate Fixed in Branch => 0.16 pre-release branch
2015-04-14 18:31 Kate Resolution open => done
2015-04-14 18:31 Kate Assigned To => Kate
2015-04-14 18:31 Kate Status resolved => closed

Notes
(0028860)
Kate   
2015-04-14 18:31   
Closing some old FRs, these might still be desirable but they don't need to have Mantis issues for them.