Dungeon Crawl Stone Soup Tracker - DCSS
|
Viewing Issue Advanced Details |
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
4614 |
Bug Report |
trivial |
have not tried |
2011-09-25 01:34 |
2013-08-22 00:21 |
|
Reporter:
|
smock |
Local or Remote:
|
Local |
|
Assigned To:
|
neil |
Operating System:
|
Windows |
|
Priority:
|
normal |
Console or Tiles:
|
Tiles |
|
Status:
|
resolved |
Product Branch:
|
0.10 ancient branch |
|
Product Version:
|
crawl_tiles-0.10-a0-795 |
Resolution:
|
done |
|
Projection:
|
none |
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.13 ancient branch |
|
|
Summary:
|
0004614: Issues with auto-remove from shipping list |
Description:
|
Two small issues.
First, the "do you want to remove from shopping list" message appears before the message describing the identity manual is displayed.
Second, when a manual of fighting is on the shopping list and another manual of fighting is identified, you receive a prompt asking if you want to remove the manual from the shopping list. There's no reason one would want to do so for manuals. |
Steps To Reproduce:
|
|
Additional Information:
|
|
System Description:
|
|
Relationships | related to | 0001402 | closed | neil | Shopping list asks to remove manual when a different kind of manual is picked up |
|
Attached Files:
|
0001-Shopping-list-Do-not-prompt-for-removing-manuals.patch [^] (1,769 bytes) 2013-08-21 16:51 [Show Content] [Hide Content]From d9636fdbc8fecd7660e91ff3300d468c9d54d470 Mon Sep 17 00:00:00 2001
From: Chris Oelmueller <chris.oelmueller@gmail.com>
Date: Wed, 21 Aug 2013 16:50:48 +0200
Subject: Shopping list: Do not prompt for removing manuals
As the comment said, but the logic not really supported, those are
consumables and as such it is very feasible to continue being interested
in them after identifying one of their kind.
Tomes of destruction technically also fit that description, but instead
of prompting for removal they are just automatically removed now when
another tome is encountered. Whyever they ended up on a shopping list at
all will remain a mystery though.
---
crawl-ref/source/shopping.cc | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/crawl-ref/source/shopping.cc b/crawl-ref/source/shopping.cc
index 23ad12f..4ab16a4 100644
--- a/crawl-ref/source/shopping.cc
+++ b/crawl-ref/source/shopping.cc
@@ -2698,16 +2698,16 @@ unsigned int ShoppingList::cull_identical_items(const item_def& item,
return 0;
}
+ // Manuals are consumable, and interesting enough to keep on list.
+ if (item.base_type == OBJ_BOOKS && item.sub_type == BOOK_MANUAL)
+ return 0;
+
// Item is already on shopping-list.
const bool on_list = find_thing(item, level_pos::current()) != -1;
const bool do_prompt =
(item.base_type == OBJ_JEWELLERY && !jewellery_is_amulet(item)
- && ring_has_stackable_effect(item))
- // Manuals and tomes of destruction are consumable.
- || (item.base_type == OBJ_BOOKS
- && (item.sub_type == BOOK_MANUAL
- || item.sub_type == BOOK_DESTRUCTION));
+ && ring_has_stackable_effect(item));
bool add_item = false;
--
1.8.3.4
|
|
Issue History |
Date Modified |
Username |
Field |
Change |
2011-09-25 01:34 |
smock |
New Issue |
|
2011-11-18 09:21 |
elliptic |
Note Added: 0015890 |
|
2012-02-24 20:05 |
raskol |
Note Added: 0017152 |
|
2012-03-18 05:23 |
Kate |
Relationship added |
related to 0001402 |
2012-03-19 08:06 |
neil |
Note Added: 0017371 |
|
2012-03-19 08:07 |
neil |
Note Edited: 0017371 |
|
2013-08-21 16:51 |
chris |
File Added: 0001-Shopping-list-Do-not-prompt-for-removing-manuals.patch |
|
2013-08-21 16:52 |
chris |
Note Added: 0023823 |
|
2013-08-22 00:21 |
neil |
Note Added: 0023827 |
|
2013-08-22 00:21 |
neil |
Status |
new => resolved |
2013-08-22 00:21 |
neil |
Fixed in Branch |
=> 0.13 development branch |
2013-08-22 00:21 |
neil |
Resolution |
open => done |
2013-08-22 00:21 |
neil |
Assigned To |
=> neil |
Notes |
|
(0015890)
|
elliptic
|
2011-11-18 09:21
|
|
Just noting that you also get incorrect prompts about removing items from your shopping list with some other items, like rings of slaying. |
|
|
(0017152)
|
raskol
|
2012-02-24 20:05
|
|
Just had this happen with two DIFFERENT manuals, which makes even less sense -- on readiding a manual of bows it asked if I wanted to remove a manual of dodging from my shopping list. |
|
|
(0017371)
|
neil
|
2012-03-19 08:06
(edited on: 2012-03-19 08:07) |
|
Partially fixed in trunk (the part about being prompted for the wrong kind of manual or for a manual that has not yet been identified). I'm leaving this one open because manuals of the same type still prompt for removal, despite the fact that they are consumable.
|
|
|
(0023823)
|
chris
|
2013-08-21 16:52
|
|
Uploaded this:
Subject: Shopping list: Do not prompt for removing manuals
As the comment said, but the logic not really supported, those are
consumables and as such it is very feasible to continue being interested
in them after identifying one of their kind.
Tomes of destruction technically also fit that description, but instead
of prompting for removal they are just automatically removed now when
another tome is encountered. Whyever they ended up on a shopping list at
all will remain a mystery though.
|
|
|
(0023827)
|
neil
|
2013-08-22 00:21
|
|
Chris's patch is in trunk (0.13-a0-2748-gab8f36f), thanks! |
|