|
Dungeon Crawl Stone Soup Tracker - DCSS
|
|||||
| Viewing Issue Advanced Details | |||||
|
|
|||||
| ID: | Category: | Severity: | Reproducibility: | Date Submitted: | Last Update: |
| 12258 | Bug Report | minor | always | 2020-05-11 11:19 | 2020-12-13 15:40 |
|
|
|||||
| Reporter: | bcadren | Local or Remote: | Both | ||
| Assigned To: | ebering | Operating System: | All | ||
| Priority: | normal | Console or Tiles: | Both | ||
| Status: | resolved | Product Branch: | 0.25 old branch | ||
| Product Version: | Resolution: | done | |||
| Projection: | none | ||||
| ETA: | none | Fixed in Branch: | |||
|
|
|||||
| Summary: | 0012258: Sif and Kiku will not give book gifts if an aquatic player is standing in deep water | ||||
| Description: |
Additionally it's weird that the Oka/Trog gift code right above it duplicates the logic of "feat_eliminates_items()" instead of calling it. It's better practice to keep this in one centralized area for similar calls in case of later changes. Both: 1350/1351 if (!(feat_has_solid_floor(grd(you.pos())) || feat_is_watery(grd(you.pos())) && species_likes_water(you.species))) and 1483: if (!feat_has_solid_floor(grd(you.pos()))) in religion.cc really should be replaced with: if (feat_eliminates_items(grd(you.pos()))) This is a correction on earlier issue: "0012257: Sif and Kiku will not give book gifts if the player is standing in shallow water." |
||||
| Steps To Reproduce: | |||||
| Additional Information: | |||||
| System Description: | |||||
| Relationships | |||||
| Attached Files: | |||||
|
|
|||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2020-05-11 11:19 | bcadren | New Issue | |||
| 2020-12-13 15:40 | ebering | Note Added: 0033969 | |||
| 2020-12-13 15:40 | ebering | Status | new => resolved | ||
| 2020-12-13 15:40 | ebering | Resolution | open => done | ||
| 2020-12-13 15:40 | ebering | Assigned To | => ebering | ||
| Notes | |||||
|
|
|||||
|
|
||||