0012251: lemuel_mausoleum overflow vaults have weird placement behavior.

Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details

ID:	Category:	Severity:	Reproducibility:	Date Submitted:	Last Update:
12251	Bug Report	minor	always	2020-05-09 02:42	2020-12-13 15:38

Reporter:	bcadren	Local or Remote:	Both
Assigned To:	ebering	Operating System:	All
Priority:	normal	Console or Tiles:	Both
Status:	resolved	Product Branch:	0.25 old branch
Product Version:		Resolution:	done
Projection:	none
ETA:	none	Fixed in Branch:

Summary:	0012251: lemuel_mausoleum overflow vaults have weird placement behavior.
Description:	Actually in several branches at least 0.22 to current. Two vaults: lemuel_mausoleum_altar_yredelemnul and lemuel_mausoleum_altar_kikubaaqudha do not use the normal "interest_check" function to tag as extra if spawning below overflow depth and instead place extra only if at a much lower depth. This effectively means that they can't place in between the lowest overflow floor (D:9) and the floor they apply extra at (D:14 and D:13 respectively). This leads to an odd behavior of being an overflow vault at D:7-D:9, being unable to place D:10-D:12 then being a potential extra altar at D:13+ which is likely unintended and could easily be fixed by replacing lines : if not you.in_branch("D") or you.absdepth() > 13 then TAGS: extra : end with : interest_check(_G) Additionally the two vaults are identical apart from which altar they place and could stand to be merged if possible.
Steps To Reproduce:
Additional Information:
System Description:
Relationships
Attached Files:

Issue History
Date Modified	Username	Field	Change
2020-05-09 02:42	bcadren	New Issue
2020-12-13 15:38	ebering	Note Added: 0033962
2020-12-13 15:38	ebering	Status	new => resolved
2020-12-13 15:38	ebering	Resolution	open => done
2020-12-13 15:38	ebering	Assigned To	=> ebering

Notes