Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
12081 Bug Report minor always 2019-10-02 22:05 2019-10-24 13:12
Reporter: Sentei Local or Remote: Both  
Assigned To: Operating System: All  
Priority: normal Console or Tiles: Both  
Status: new Product Branch: 0.24 old branch  
Product Version: 0.24-a0-736-g4e6fe308c7 Resolution: open  
Projection: none      
ETA: none Fixed in Branch:  
Summary: 0012081: Batty enemies don't indicate that they are wandering/haven't noticed you
Description: Problem seen on webtiles for at least a few months.

With high stealth enemies that wander onto screen have a question mark on them and upon examination their status is (hasn't noticed you).

Batty enemies don't have this enabled, or it isn't working.

Seen quite a few times when playing, most noticeable in midgame against harpies.

Also testable on the first floor with bats - clear first floor on stealthy character, leave a bat alive, hide from it and let it wander into your screen. It might not notice you and just walk out of vision or fly sideways without having the question mark or the status (hasn't noticed you).
Steps To Reproduce:
Additional Information:
System Description:
Relationships
Attached Files:
Issue History
Date Modified Username Field Change
2019-10-02 22:05 Sentei New Issue
2019-10-24 13:12 Sentei Note Added: 0033536

Notes
(0033536)
Sentei   
2019-10-24 13:12   
not shown as wandering wandering because after their one attack they're set to seek for the rest of their movement, so its not displayed they're wandering

tries to set wandering(multiple times)
https://github.com/crawl/crawl/blob/bfa02ace7b0344c25e6f2ac9491636ff137fe48b/crawl-ref/source/mon-act.cc#L1897 [^]
sets to seek instead, so not displaying wandering
https://github.com/crawl/crawl/blob/fb3efd073d7df51369fcb7dd9449ce625ac4e44d/crawl-ref/source/mon-behv.cc#L714 [^]
only checks for wandering
https://github.com/crawl/crawl/blob/bfa02ace7b0344c25e6f2ac9491636ff137fe48b/crawl-ref/source/directn.cc#L3098 [^]
same
https://github.com/crawl/crawl/blob/6dd8730de2082ba4e29eb1a552753443cc4a8422/crawl-ref/source/mon-info.cc#L1236 [^]

so batty enemies aren't shown/logged to be wandering, even though in game logic they are

not displaying stabbable - ?(which can be interpreted as wandering in webtiles)
adds the ? mark to the tile in webtiles
https://github.com/crawl/crawl/blob/bfa02ace7b0344c25e6f2ac9491636ff137fe48b/crawl-ref/source/tilepick.cc#L1946 [^]
check for MB_stabable, 
https://github.com/crawl/crawl/blob/6dd8730de2082ba4e29eb1a552753443cc4a8422/crawl-ref/source/mon-info.cc#L571 [^]
which checks for mon_looks_distracted
https://github.com/crawl/crawl/blob/bfa02ace7b0344c25e6f2ac9491636ff137fe48b/crawl-ref/source/mon-util.cc#L3536 [^]
which looks if mons isnt stabable
https://github.com/crawl/crawl/blob/bfa02ace7b0344c25e6f2ac9491636ff137fe48b/crawl-ref/source/mon-util.cc#L3530 [^]
and in stab types finds that batty enemies arent stabable
https://github.com/crawl/crawl/blob/883716c04b0ca8447033d002a3d9b5a051e69b5d/crawl-ref/source/fight.cc#L408 [^]

so no ? indicator either

I didnt know that batty enemies arent distract stabable, seems pretty obscure? and even if they arent stabable the distracted stab indicator, which is also be used as an enemy is wandering indicator could be a different check than the actual stab damage checker