Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details
11839 Bug Report minor always 2019-01-22 07:35 2019-01-22 18:56
minmay Both  
All  
normal Both  
new 0.23 old branch  
0.23-a0-726-g9fa1570 open  
none    
none  
0011839: Potion Petition ignores "no potion heal"
Curing and heal wounds from Potion Petition ignore the no potion heal mutation (and robe of Vines), giving their full healing amount even when the player should receive less or none.
Issue History
2019-01-22 07:35 minmay New Issue
2019-01-22 18:56 Stenella Note Added: 0032959

Notes
(0032959)
Stenella   
2019-01-22 18:56   
This appears to be by design; it seems the original effect was renamed due to its effect, rather than its intention.

https://github.com/crawl/crawl/commit/303077ceedd3078c3bc0d2fb60e691a8e1447348 [^]

https://github.com/crawl/crawl/blob/master/crawl-ref/source/potion.cc#L1376 [^]
https://github.com/crawl/crawl/blob/master/crawl-ref/source/potion.cc#L190 [^]

are the relevant code paths. Potion-petition calls the effects with potion=false, while the check for nopotionheal is dependent on potion=true.