|
Dungeon Crawl Stone Soup Tracker - DCSS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
11691 |
Patches |
tweak |
N/A |
2018-09-23 09:39 |
2018-09-23 10:01 |
|
|
Reporter:
|
collin38 |
Local or Remote:
|
Remote |
|
|
Assigned To:
|
aidanholm |
Operating System:
|
Online |
|
|
Priority:
|
normal |
Console or Tiles:
|
WebTiles |
|
|
Status:
|
resolved |
Product Branch:
|
longterm development (0.31+) |
|
|
Product Version:
|
c87c613cd2ed94e50109c41e137e6c3a |
Resolution:
|
done |
|
|
Projection:
|
none |
|
|
|
|
ETA:
|
none |
Fixed in Branch:
|
longterm development (0.31+) |
|
|
|
Summary:
|
0011691: Prevent spectators with hidden chat from counting in total. |
|
Description:
|
When a spectator has hidden their chat with "/hide (forever)", They are removed from the spectators list, but they still contribute to the number of spectators. This is confusing; if a user isn't in the list, they shouldn't be in the total count. I've attached a screenshot which shows 2 spectators but only lists 1 (beem)
This has the intended side effect of allowing users to spectate without disturbing the player. For example, I was asked "plz DONT SPEC ME." For such users it would be nice if there was a way to watch without interrupting. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
|
System Description:
|
|
| Relationships | |
|
Attached Files:
|
 0001-Prevent-spectators-with-chat-hidden-from-counting-in.patch [^] (987 bytes) 2018-09-23 09:39 [Show Content] [Hide Content]From bb66aaa17fb16c9eb63e8540a4533c6cb9089a48 Mon Sep 17 00:00:00 2001
From: Collin Johnston <collin389@gmail.com>
Date: Sun, 23 Sep 2018 00:14:35 -0700
Subject: [PATCH] Prevent spectators with chat hidden from counting in the
total.
---
crawl-ref/source/webserver/process_handler.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/crawl-ref/source/webserver/process_handler.py b/crawl-ref/source/webserver/process_handler.py
index 0e141ef2a5..e0564b7bb6 100644
--- a/crawl-ref/source/webserver/process_handler.py
+++ b/crawl-ref/source/webserver/process_handler.py
@@ -424,7 +424,8 @@ class CrawlProcessHandlerBase(object):
self.update_watcher_description()
def watcher_count(self):
- return len([w for w in self._receivers if w.watched_game])
+ return len([w for w in self._receivers
+ if w.watched_game and not w.chat_hidden])
def send_client_to_all(self):
for receiver in self._receivers:
--
2.14.1
 invis_spectator.PNG [^] (3,806 bytes) 2018-09-23 09:41
 |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2018-09-23 09:39 |
collin38 |
New Issue |
|
|
2018-09-23 09:39 |
collin38 |
File Added: 0001-Prevent-spectators-with-chat-hidden-from-counting-in.patch |
|
|
2018-09-23 09:41 |
collin38 |
File Added: invis_spectator.PNG |
|
|
2018-09-23 09:41 |
collin38 |
Issue Monitored: collin38 |
|
|
2018-09-23 10:00 |
aidanholm |
Note Added: 0032643 |
|
|
2018-09-23 10:00 |
aidanholm |
Status |
new => resolved |
|
2018-09-23 10:00 |
aidanholm |
Fixed in Branch |
=> longterm development (0.23+) |
|
2018-09-23 10:00 |
aidanholm |
Resolution |
open => done |
|
2018-09-23 10:00 |
aidanholm |
Assigned To |
=> aidanholm |